Repository navigation
Conversation
Almenon
marked this pull request as draft
February 14, 2021 18:43
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## master #233 +/- ##
==========================================
+ Coverage 94.94% 96.02% +1.07%
==========================================
Files 1 1
Lines 178 176 -2
Branches 43 41 -2
==========================================
Hits 169 169
+ Misses 9 7 -2
Continue to review full report at Codecov.
|
Sorry, something went wrong.
should try to keep consistent to minimize API changes for upstream devs
Almenon
marked this pull request as ready for review
March 8, 2021 05:21
this breaks unit tests for some reason :(
I went in favor of a native solution. LineTransformStream had some bugs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.