FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Update default python path for windows platform by jamesgeorge007 · Pull Request #168 · extrabacon/python-shell · GitHub

  1. extrabacon
  2. python-shell

Repository navigation

Update default python path for windows platform - #168

Merged
Almenon merged 1 commit into
extrabacon:masterfrom
jamesgeorge007:hotfix/update-path
Dec 29, 2018
ConversationCommits (1)ChecksFiles changed
Merged

Update default python path for windows platform #168
Almenon merged 1 commit into
extrabacon:masterfrom
jamesgeorge007:hotfix/update-path

Conversation

jamesgeorge007 commented Dec 28, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

closes #167
Python is available as py in windows machines by default and not python unless explicitly setting it as an environment variable.

Exception being thrown:

jamesgeorge007 mentioned this pull request Dec 28, 2018
Closed
Almenon self-requested a review December 29, 2018 03:09
Almenon added the bug label Dec 29, 2018
Almenon merged commit b4e6746 into extrabacon:master Dec 29, 2018

Almenon commented Dec 29, 2018

Copy link
Copy Markdown
Collaborator

wow, i never knew that py existed. Interesting.

Almenon modified the milestones: 1.0.6, v1.0.6, v1.0.7 Dec 29, 2018

Almenon commented Feb 5, 2019

Copy link
Copy Markdown
Collaborator

Turns out py is not always availible either. If python is installed for a specific user ("install launcher for all users" is not checked) then py is not put in the windows directory.

https://docs.python.org/3/using/windows.html#installation-steps

jamesgeorge007 deleted the hotfix/update-path branch February 5, 2019 03:07

jamesgeorge007 commented Feb 5, 2019

Copy link
Copy Markdown
Contributor Author

@Almenon In that case the user is required to set an environment variable corresponding to the python path right?
If that's the case we shall access it with process.env 🤔

Almenon commented Feb 5, 2019 •
edited
Loading

Copy link
Copy Markdown
Collaborator

No - for some reason adding python to path is optional and not even checked by default

Almenon mentioned this pull request Mar 8, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Almenon Awaiting requested review from Almenon

Assignees

jamesgeorge007

Labels

bug

Projects

None yet

Milestone

v1.0.7

Development

Successfully merging this pull request may close these issues.

Throwing errors on executing python script

2 participants

Back | FazBrowse Home | New Git URL