Repository navigation
Use kill signal's returned value - #256
Merged
Almenon merged 1 commit intoOct 9, 2021
Merged
Almenon merged 1 commit into
Almenon merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Almenon
self-requested a review
October 5, 2021 15:52
Almenon
approved these changes
Oct 9, 2021
Almenon
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
👍
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
a new version 3.0.1 has been published with this change. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On calling kill, set terminated to the result of childProcess.kill().
This is useful as you can try a variety of kill signals by checking this.terminated until it is successfully killed.
I think this is somewhat possible already by listening for an error event for a failed termination, but this method allows you to loop the kill method without relying on an external callback.