FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: parse tracebacks after stderr prefixes by alceops · Pull Request #323 · extrabacon/python-shell · GitHub

  1. extrabacon
  2. python-shell

Repository navigation

fix: parse tracebacks after stderr prefixes - #323

Open
alceops wants to merge 1 commit into
extrabacon:masterfrom
alceops:fix-parse-prefixed-traceback
ConversationCommits (1)ChecksFiles changed
Open

fix: parse tracebacks after stderr prefixes#323
alceops wants to merge 1 commit into
extrabacon:masterfrom
alceops:fix-parse-prefixed-traceback

Conversation

alceops commented Apr 28, 2026

Copy link
Copy Markdown

Summary

  • parse Python tracebacks even when stderr contains prefix log lines before the traceback header
  • keep the parsed traceback focused on the traceback block
  • add a regression fixture/test for prefixed stderr output

Validation

  • npm ci
  • npm test -- --grep "parseError|prefixed logs" (4 passing)

Fixes #309.

This was referenced Apr 28, 2026
Open
Open

StantonMatt commented Jun 1, 2026

Copy link
Copy Markdown

I fetched this branch locally to help with maintainer triage.

Validation:

  • npm test -- --grep "prefixed logs" -> 1 passing
  • npm test -> 44 passing

The fix matches the reported shape in #309: prefix stderr text is ignored for traceback parsing, while the parsed traceback still starts at Traceback (most recent call last):. I did not spot a conflict with the existing plain-traceback behavior in the full suite.

PNHD approved these changes Sep 3, 2026
View reviewed changes

PNHD left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Verified the current head against #309 on an LF-safe checkout. The prefixed-traceback regression, full npm test suite, repository Prettier check, and diff hygiene all pass locally. The change stays scoped to traceback parsing without disturbing the existing plain-traceback path.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
PNHD PNHD approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The error object doesn't have Error & traceback properties.

3 participants

Back | FazBrowse Home | New Git URL