Repository navigation
Avoid shell parsing for Python helper commands - #327
Open
StantonMatt wants to merge 1 commit into
Open
StantonMatt wants to merge 1 commit into
StantonMatt wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Signed-off-by: Matthew Stanton <stantonmatthewj@gmail.com>
PNHD
approved these changes
Sep 2, 2026
PNHD
left a comment
Copy link
Copy Markdown
There was a problem hiding this comment.
Reviewed current head 0208d08 with the shell-execution boundary in mind.
Passing the Python executable and arguments separately through execFile/execFileSync fixes the path-with-spaces bug from #181 and removes shell interpretation from checkSyntaxFile(), getVersion(), and getVersionSync() without changing their observable stdout/stderr contracts.
The focused regressions cover both spaced script paths and spaced executable paths. LGTM.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #181.
Why
The previous implementation built commands like ${pythonPath} --version. That breaks when the Python executable path contains spaces and also leaves these helpers dependent on shell parsing. Passing the executable and arguments separately avoids quoting issues.
Verification