Repository navigation
fix: split process output on \n instead of os.EOL - #332
Open
Bolt4243 wants to merge 1 commit into
Open
Bolt4243 wants to merge 1 commit into
Bolt4243 wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
NewlineTransformer split stdout/stderr on os.EOL. On Windows that is \r\n, so output using bare \n line endings was never split into messages: the data was buffered and dropped, because _flush runs after the stream's end handler has already resolved the run()/end() callback. Normal print() worked only because Python's text-mode stdout translates \n to \r\n on Windows. Split on /\r?\n/ so both line endings are handled.
PNHD
approved these changes
Sep 2, 2026
PNHD
left a comment
Copy link
Copy Markdown
There was a problem hiding this comment.
Reviewed current head 9fe76e4 against #331.
Splitting on /\r?\n/ fixes bare-LF output on Windows while preserving CRLF handling. Because _lastLineData is prepended before splitting, a CRLF pair split across two stream chunks is still reconstructed and emitted as one normal line.
The focused transformer tests cover both LF and CRLF without expanding into the separate bare-CR behavior from #325. LGTM.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #331.
NewlineTransformer split stdout/stderr on os.EOL. On Windows that is \r\n, so output using bare \n line endings was never split into messages: the data was buffered in _lastLineData and dropped, because _flush runs after the stream's end handler has already resolved the run()/end() callback. print() worked only because Python's text-mode stdout translates \n to \r\n on Windows.
Split on /\r?\n/ so both line endings are handled.
Added a regression test against the exported NewlineTransformer (deterministic and OS independent). It fails on the previous code for the bare-\n case and passes with the fix.