This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ -315,7 +315,7 @@ Fires when the process has been terminated, with an error or not.
#### event: `pythonError`
Fires when the process terminates with a non-zero exit code.
Fires when the process terminates with a non-zero exit code or an output parser throws before normal completion. Parser exceptions are also passed to `.end()` and reject `PythonShell.run()`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it('should not treat stderr listener exceptions as parser errors', function (done) {
let splitter = new NewlineTransformer();
let pyshell = new PythonShell(
'exit-code.py',
{ mode: 'text' },
null,
splitter,
);
let listenerError = new Error('stderr listener failed');
let thrownError: Error;
pyshell.on('stderr', function () {
throw listenerError;
});
try {
splitter.emit('data', 'hello');
} catch (err) {
thrownError = err;
}
should.exist(thrownError);
thrownError.should.be.exactly(listenerError);
pyshell.end(function (err) {
should.not.exist(err);
done();
});
});
it('should not be invoked when mode is "binary"', function (done) {
let pyshell = new PythonShell('stderrLogging.py', {
stderrParser: 'binary',
Expand Down
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle parser errors without crashing #334
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
Handle parser errors without crashing #334
Filter by extension
Viewed files
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing