| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Update `_isNULL` and `_notNULL` constants to allow checks to run correctly
Uppercased right expression for type consistency specific to these methods in `isNull` and `isNotNull`
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## master #213 +/- ##
============================================
+ Coverage 90.30% 90.76% +0.46%
Complexity 838 838
============================================
Files 14 14
Lines 2083 2058 -25
============================================
- Hits 1881 1868 -13
+ Misses 202 190 -12 ☔ View full report in Codecov by Sentry.
|
Sorry, something went wrong.
Fix tests
Those constants also suppose to build create the actual SQL query string format. There might not be enough or no tests covering them. The ezFunctionsTest.php does not actually touch any database. Seems the Windows Github Actions Ci needs fixing now. |
Sorry, something went wrong.
It failed the test when I left the $y value lowercase because it was doing an assertive array check in the test files, so I made them uppercase to match the values defined in the constants. I've been trying to work out for weeks why the NULL conditions weren't working but I only actually looked into it last night because I needed it for a query to run properly. |
Sorry, something went wrong.
There was a problem hiding this comment.
The naming of the constants and meaning actually represent contents without spacing.
Seems there might be some logic bugs elsewhere that should be looked at too. see
Line 334 in 4bc6a25
Line 386 in 4bc6a25
This construction will actually produced IS NOT NULL null the $y = 'null' not really needed.
Sorry, something went wrong.
After looking a little further, there are other issues as mentioned, seems the need for more coverage tests should be done too. Plus test under PHP 8.1 for compatibility, this part I been wanting to do for over 2 months now. Just not in the right mind to address issues, got many other things I'm working on. |
Sorry, something went wrong.
Yea I had originally tried removing this as well but it wouldn't parse without those values so that's why I used the solution that I have as that does parse with no issues. Unfortunately, I'm in the same space as you otherwise I would have sorted this earlier myself. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Update _isNULL and _notNULL constants to allow checks to run correctly.
Discovered that the isNull and isNotNull where conditions were not firing correctly due to incorrectly declared constants.