Updated print function's arguments in borg.py. - #37
Merged
faif merged 1 commit intoJan 2, 2014
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
faif
pushed a commit
that referenced
this pull request
Jan 2, 2014
Updated print function's arguments in borg.py.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@faif, Thanks for your devotion about this great python stuff.
BTW, regarding borg.py, I found the print function works as expected in python 3 environment. But it seems that it does not in python 2 environment.
Python 3:
Python 2:
pyvers@www1021uh:~/sandbox_2.7.5$ python --version Python 2.7.5 pyvers@www1021uh:~/sandbox_2.7.5$ python ../borg.py ('rm1:', <__main__.Borg instance at 0x1a620e0>) ('rm2:', <__main__.Borg instance at 0x1a62128>) ('rm1:', <__main__.Borg instance at 0x1a620e0>) ('rm2:', <__main__.Borg instance at 0x1a62128>) ('rm1 id:', 27664608) ('rm2 id:', 27664680) ('rm1:', <__main__.Borg instance at 0x1a620e0>) ('rm2:', <__main__.Borg instance at 0x1a62128>) ('rm3:', <__main__.YourBorg instance at 0x1a62170>) pyvers@www1021uh:~/sandbox_2.7.5$This is because the argument of print function is parsed as tuple in python 2 environment.
So I changed the argument of print function using str.format(). This works as expected in both environments, python 2 and 3. (And I think this is proper way to handle string formatting in python 3 environment, as described like here; http://docs.python.org/3.2/tutorial/inputoutput.html#old-string-formatting )
Python 3:
Python 2:
It is much appreciated if you would take a look at this pull request.
Thanks.