| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
Unrelated, but I'm not sure it makes sense to translate the time zone names at all, since they're identifiers. Here's an example: time_zone: [África/Argel, África/Cairo, África/Casablanca, África/Harare, ...]/faker/lib/locales/es-MX.yml:15
This quote from Theory and pragmatics of the tz code and data - Timezone identifiers hints that the timezone names can be mapped to translations, but the unique identifier aspect gets lost if the timezone's name itself is translated. |
Sorry, something went wrong.
…Atlantic/Cape_Verde in en.faker.address.time_zone
There was a problem hiding this comment.
excellent, thanks for adding tests!
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Motivation / Background
Fixes: #2928
This Pull Request has been created because our tests using Faker time zones mostly pass, but fails when the Atlantic/Cabo_Verde time zone is returned. We validate that time zones are valid IANA identifiers, and Atlantic/Cabo_Verde is called Atlantic/Cape_Verde in the Time Zone Database.
Additional information
Checklist
Before submitting the PR make sure the following are checked: