FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Update ukrainian city locales to the modern ones by SleekMutt · Pull Request #3127 · faker-ruby/faker · GitHub

/ faker Public

Update ukrainian city locales to the modern ones - #3127

Merged
stefannibrasil merged 1 commit into
faker-ruby:mainfrom
SleekMutt:updated-ukrainian-cities-names-to-modern
Nov 19, 2025
ConversationCommits (1)ChecksFiles changed
Merged

Update ukrainian city locales to the modern ones#3127
stefannibrasil merged 1 commit into
faker-ruby:mainfrom
SleekMutt:updated-ukrainian-cities-names-to-modern

Conversation

SleekMutt commented Nov 3, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Motivation / Background

This Pull Request has been created because since the introduction of ukrainian locales, some cities have been renamed, so the locales need to be updated.

Additional information

List of renamed cities.

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug, refactor something, or add a feature.
  • Tests and Rubocop are passing before submitting your proposed changes.

If you're proposing a new generator or locale:

  • Double-check the existing generators documentation to make sure the new generator you want to add doesn't already exist.
  • You've reviewed and followed the Contributing guidelines.

stefannibrasil reviewed Nov 18, 2025
View reviewed changes

stefannibrasil left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

All the new names are cities, according to my search, except for Хрустальний, which seems to be a movie. Can you check that? Thanks!

Comment thread lib/locales/uk.yml
- Конотоп
- Краматорськ
- Красний Луч
- Хрустальний

stefannibrasil Nov 18, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

When I search for this, I get a movie instead of a city. Do you see a city when you search for it?

SleekMutt Nov 18, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Hey, thanks for the notice. Yeah, it's both a movie name and a city name

https://en.wikipedia.org/wiki/Khrustalnyi
https://uk.wikipedia.org/wiki/%D0%A5%D1%80%D1%83%D1%81%D1%82%D0%B0%D0%BB%D1%8C%D0%BD%D0%B8%D0%B9

stefannibrasil merged commit 94adefd into faker-ruby:main Nov 19, 2025
8 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

stefannibrasil stefannibrasil approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL