FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Bump rubocop version and fix offenses by stefannibrasil · Pull Request #3198 · faker-ruby/faker · GitHub

Bump rubocop version and fix offenses - #3198

Merged
stefannibrasil merged 1 commit into
mainfrom
sb-rubocop-v1.84.0-3197
Jan 29, 2026
Merged

Bump rubocop version and fix offenses#3198
stefannibrasil merged 1 commit into
mainfrom
sb-rubocop-v1.84.0-3197

Conversation

stefannibrasil commented Jan 29, 2026
edited
Loading

Copy link
Copy Markdown
Contributor

I am removing the version from Gemfile since we don't have any reason to pin it to a specific version. We keep the dependency up to date.

Closes #3197

Offenses fixed:

  • lib/faker/default/string.rb:27:25: C: [Correctable] Style/ModuleMemberExistenceCheck: Use include?(Enumerable) instead.
  • lib/helpers/unique_generator.rb:33:5: C: [Correctable] Style/EmptyClassDefinition: Prefer a two-line class definition over Class.new for classes with no body.

I am removing the version from Gemfile since we don't
have any reason to pin it to a specific version. We
keep the dependency up to date.

Offenses fixed:
- lib/faker/default/string.rb:27:25: C: [Correctable] Style/ModuleMemberExistenceCheck: Use include?(Enumerable) instead.
- lib/helpers/unique_generator.rb:33:5: C: [Correctable] Style/EmptyClassDefinition: Prefer a two-line class definition over Class.new for classes with no body.
stefannibrasil merged commit 30e8a92 into main Jan 29, 2026
9 checks passed
stefannibrasil deleted the sb-rubocop-v1.84.0-3197 branch January 29, 2026 21:25
stefannibrasil added a commit that referenced this pull request Jan 30, 2026
I am removing the version from Gemfile since we don't have any reason to pin it to a specific version. We keep the dependency up to date.

Offenses fixed:
- lib/faker/default/string.rb:27:25: C: [Correctable] Style/ModuleMemberExistenceCheck: Use include?(Enumerable) instead.
- lib/helpers/unique_generator.rb:33:5: C: [Correctable] Style/EmptyClassDefinition: Prefer a two-line class definition over Class.new for classes with no body.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bump rubocop to 1.84.0

1 participant


Back | FazBrowse Home | New Git URL