Amend province for zh-CN - #3229
Conversation
Sorry, something went wrong.
|
Thank you for the discussion. I would prefer we mention that in the docs. Could you do that instead? In Canada, for example, we also use provinces instead of states. If we went down this route, we would have to update all locales that are similar. Plus, the generator uses keyword arguments with state, and changing these to keep things standard would involve lots of work. |
Sorry, something went wrong.
|
Thanks for your advice. 👍 I've updated the document. Before the commit, I had checked the codebase and found that some files also used the word province.
It's true. However, I believe that unless some contributor explicitly indicates that modifications are necessary in some locale, the maintainers generally does not need to make the adjustments themselves. Moreover, the address generator is frequently used, so I think it is necessary to enhance the semantic accuracy. This is precisely the significance of localization, rather than just translation. |
Sorry, something went wrong.
Motivation / Background
In China, we use province instead of state. In the original localization, the default term state was used.
To address this, I adjusted it to province and used the standard term of each province rather than an abbreviation.
However, there is an issue with this PR: to maintain backward compatibility, I used YAML's anchor syntax. What do you think — is this necessary?
Checklist
Before submitting the PR make sure the following are checked:
If you're proposing a new generator or locale: