Localize Faker::Job for de, de-CH, fr, fr-CH and it - #3272
Open
huerlisi wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
`Faker::Job` only had data for en (and hy, pt-BR), so every other locale silently returned English titles, e.g. `it` produced "Lead Banking Developer" and `de` produced "Design Administrator". Add localized `job` data for the German, French and Italian locales. Each provides the keys `Faker::Job` consumes — `field`, `seniority`, `position`, `key_skills` — plus a `title` template reordered to fit the language (adjective-after-noun for fr/it, e.g. "Directeur Régional", "Dirigente Contabilità"). As with the English generator, titles are synthetic combinations. `fr` follows the lib/locales/fr/ subfolder convention (new fr/job.yml); the other locales get a top-level `job:` block. `de-CH`/`fr-CH` carry their own copies since they do not fall back to `de`/`fr`. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Author
|
In the fr locale job.yml is it's own file. The other touched locales don't follow this pattern, but the docs mention this as preferable. Should I keep as is, or is this the right moment to introduce a directory for the locales I touched? |
Sorry, something went wrong.
thdaraujo
reviewed
Jul 4, 2026
Comment thread
test/test_de_ch_locale.rb
| assert_kind_of String, Faker::Job.key_skill | ||
|
|
||
| # Guard against Faker::Job silently falling back to the English data. | ||
| fields = I18n.translate('faker.job.field', locale: :'de-CH') |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
do we really need this?
Sorry, something went wrong.
thdaraujo
reviewed
Jul 4, 2026
Comment thread
test/test_de_locale.rb
| assert_kind_of String, Faker::Job.key_skill | ||
|
|
||
| # Guard against Faker::Job silently falling back to the English data. | ||
| fields = I18n.translate('faker.job.field', locale: :de) |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
same comment here
Sorry, something went wrong.
thdaraujo
reviewed
Jul 4, 2026
Comment thread
test/test_fr_ch_locale.rb
| assert_kind_of String, Faker::Job.key_skill | ||
|
|
||
| # Guard against Faker::Job silently falling back to the English data. | ||
| fields = I18n.translate('faker.job.field', locale: :'fr-CH') |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
and here
Sorry, something went wrong.
thdaraujo
reviewed
Jul 4, 2026
Comment thread
test/test_it_locale.rb
Comment on lines
+69
to
+70
| # Guard against Faker::Job silently falling back to the English data. | ||
| fields = I18n.translate('faker.job.field', locale: :it) |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Suggested change
| # Guard against Faker::Job silently falling back to the English data. | |
| fields = I18n.translate('faker.job.field', locale: :it) |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
At least 1 approving review is required to merge this pull request.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Faker::Job only had data for en (and hy, pt-BR), so every other
locale silently returned English job titles:
This Pull Request adds localized job data for the German, French and
Italian locales. Each provides the keys Faker::Job consumes — field,
seniority, position, key_skills — plus a title template reordered
to fit the language (adjective-after-noun for fr/it). As with the English
generator, titles are synthetic combinations.
Additional information
Output after the change:
Notes:
fr/job.yml); the other locales get a top-level job: block.
de / fr.
education_level are not read by any Faker::Job method).
Tests assert Faker::Job.field is a member of the locale's own field list,
guarding against a regression back to the English fallback.
Checklist