FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add more books and publishers by tejasbubane · Pull Request #484 · faker-ruby/faker · GitHub

Add more books and publishers - #484

Merged
stympy merged 1 commit into
faker-ruby:masterfrom
tejasbubane:more-books
Dec 9, 2015
Merged

Add more books and publishers#484
stympy merged 1 commit into
faker-ruby:masterfrom
tejasbubane:more-books

Conversation

Copy link
Copy Markdown
Contributor

stympy added a commit that referenced this pull request Dec 9, 2015
stympy merged commit bc8b7c8 into faker-ruby:master Dec 9, 2015

Copy link
Copy Markdown

Thanks! This would help a lot and I really appreciate the time you took to add this. When can I use this in the gem?

Copy link
Copy Markdown
Contributor Author

@harsh183 This will be available when the next release 1.6.2 happens. Releases are listed here: https://github.com/stympy/faker/releases

Meanwhile you can go ahead and use the master branch in your Gemfile:

gem "faker", git: "git://github.com/stympy/faker.git", branch: "master"

Copy link
Copy Markdown

Thanks.

Thanks for the code snippet as well, I will use it in my code.

I never knew one could directly take branches off git as well in a
gemfile. I guess I learn new things everyday.

On Mon, Jan 18, 2016 at 12:16 PM Tejas Bubane notifications@github.com
wrote:

@harsh183 https://github.com/harsh183 This will be available when the
next release 1.6.2 happens. Releases are listed here:
https://github.com/stympy/faker/releases

Meanwhile you can go ahead and use the master branch in your Gemfile:

gem "faker", git: "git://github.com/stympy/faker.git", branch: "master"


Reply to this email directly or view it on GitHub
#484 (comment).

Copy link
Copy Markdown
Contributor Author

@harsh183 Glad it helped. 👍

Copy link
Copy Markdown

Thanks a lot for replying to this and making the changes to the code. I
mean you improved one of my most favorite gems I use often.

On Tue, Jan 19, 2016 at 12:04 AM Tejas Bubane notifications@github.com
wrote:

@harsh183 https://github.com/harsh183 Glad it helped. [image: 👍]


Reply to this email directly or view it on GitHub
#484 (comment).

gkrimer added a commit to gkrimer/faker that referenced this pull request Apr 14, 2026
The title has appeared twice in the book title list since faker-ruby#484 (Dec 2015),
when the list was bulk-replaced with titles sourced from Wikipedia.
Both Reginald Hill's novel and Dickens' A Tale of Two Cities Book 1
share the name, so the source list had two entries that were pasted
without deduplication.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
stefannibrasil pushed a commit that referenced this pull request Apr 14, 2026
The title has appeared twice in the book title list since #484 (Dec 2015),
when the list was bulk-replaced with titles sourced from Wikipedia.
Both Reginald Hill's novel and Dickens' A Tale of Two Cities Book 1
share the name, so the source list had two entries that were pasted
without deduplication.

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL