Use faker for tests - #30
Closed
ebreton wants to merge 8 commits into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Merge in tiangolo/master
Aligning with tiangolo master
Copy link
Copy Markdown
Member
|
Thanks! In fact, I initially used Faker (for the Flask version), but as currently the DB gets polluted with tests that are not removed afterwards, I started getting collisions frequently. And I realized that I didn't need real data, just random strings that I could check. Let's leave this on standby until I update the tests to use Starlette's TestClient, and we can solve automatic rollbacks in tests. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Yes, sounds good. I will create another PR in due time 👍 |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Thanks! |
Sorry, something went wrong.
alejsdev
added a commit
that referenced
this pull request
Dec 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because tests should be first citizens pieces of code... they deserve proper random (faked) data 🎒
Faker is a new dependency, but only for tests (not included in backend dockerfile)