FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

📝 Update define relationships attributes docs: `Optional[Team]` -> `Team | None` by scku208 · Pull Request #1070 · fastapi/sqlmodel · GitHub

Repository navigation

📝 Update define relationships attributes docs: Optional[Team] -> Team | None - #1070

Closed
scku208 wants to merge 2 commits into
fastapi:mainfrom
scku208:update_relationship_attributes_docs
Closed

scku208 wants to merge 2 commits into
fastapi:mainfrom
scku208:update_relationship_attributes_docs

Conversation

scku208 commented Aug 13, 2024

Copy link
Copy Markdown

For users new to SQLModel, the documentation might be confusing. It is recommended to focus on explanations for Python 3.10+ or to include additional parenthetical notes explaining differences from earlier versions.

github-actions Bot added the docs Improvements or additions to documentation label Aug 13, 2024

Copy link
Copy Markdown
Contributor

scku208 commented Aug 13, 2024 •
edited
Loading

Copy link
Copy Markdown
Author

I apologize, but the final reference to Optional[Team] in that particular paragraph should also be updated to Team | None. (also, Optional[int] should be updated to int | None)

alejsdev changed the title Update define relationships attributes docs: Optional[Team] -> Team | None 📝 Update define relationships attributes docs: Optional[Team] -> Team | None Aug 22, 2024

github-actions Bot commented Sep 3, 2024

Copy link
Copy Markdown
Contributor

svlandeg marked this pull request as draft February 24, 2025 10:40

Copy link
Copy Markdown

I apologize, but the final reference to Optional[Team] in that particular paragraph should also be updated to Team | None. (also, Optional[int] should be updated to int | None)

@scku208 could you update the PR with this change so we can get this ready to be merged?

Copy link
Copy Markdown
Member

Thanks! This was covered in #1351, so I'll close this one now. 🤓 ☕

tiangolo closed this Apr 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL