Repository navigation
✅ Refactor test_enums to make them independent of previous imports - #1095
Merged
tiangolo merged 1 commit intoAug 31, 2024
Merged
tiangolo merged 1 commit into
tiangolo merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✅ Refactor test_enums to make them independent of previous imports
These tests are currently passing only because they are the first ones to be imported. But adding other tests before them, as in #1093 makes them fail.
With this refactor, because SQLModel and the metadata are cleared in a text fixture, and then the models are imported/reloaded, they are independent of anything else that could be loaded or registered.