✨ Support `pattern` parameter by stickm4n · Pull Request #1231 · fastapi/sqlmodel · GitHub

I faced this issue with Pydantic V2 and there is a simple workaround to it by passing the pattern Field parameter as schema extra:

Ex:

class MyClass(SQLModel)
    id: str = Field(unique=True, schema_extra={'pattern': r"^\d{5}$"})

I don't know if this issue was already fixed in another branch, I saw there was a temporary PR already made but closed.

@tiangolo @alejsdev or some other maintainer... could you please review this issue?

…param)

Thanks for the PR! We're going through the backlog of PRs right now, and will get back to you once we've had the time to review this and consider the (breaking) change 🙏

@svlandeg Nice to hear you are taking action on this matter. There is remark, the parameter the was renamed between Pydantic v1 and v2 is regex-> pattern, not as listed in the PR.

The suggestion I made in the PR was to keep both versions compatible when upgrading, but there is an alternative, which is not managing the change between them and just provide the proper type hints.

If you want me to update the PR just let me know, IDK which approach is more adequate for the project.

LGTM!

This keep supporting old ways of specifying pattern (regex parameter, and pattern via schema_extra), but emits warnings in these cases. We will remove this support in the future versions.

…tern`

@YuriiMotov I added a blocking comment, please review it and let me know if you will address it (since it was your change to clean the code and prepare the PR) or should I? Anyway I will be around... 🤠

PS: Annotations were updated for re.Pattern support.

guys what's the news on this?
mind you the regex parameter is ignored in validation and using it blindly could lead to potential bugs.

LGTM!

Add compatibility for Pydantic V2 regex (renamed param from regex to …

6afa967

…param)

stickm4n force-pushed the main branch from 8559f01 to 6afa967 Compare December 28, 2024 13:27

svlandeg added the breaking label Feb 20, 2025

svlandeg changed the title Add compatibility for Pydantic V2 regex (renamed param from regex to … 💥 Rename regex to param to provide compatibility with Pydantic V2 Feb 20, 2025

Merge branch 'fastapi:main' into main

e19734f

Merge branch 'main' into main

2d6bb87

This comment was marked as resolved.

Sign in to view

stickm4n changed the title 💥 Rename regex to param to provide compatibility with Pydantic V2 💥 Rename regex to pattern to provide compatibility with Pydantic V2 Aug 8, 2025

This comment was marked as resolved.

Sign in to view

YuriiMotov added the waiting label Aug 23, 2025

This comment was marked as resolved.

Sign in to view

github-actions Bot removed the waiting label Aug 28, 2025

stickm4n force-pushed the main branch 2 times, most recently from a5e8961 to 0b9f96f Compare August 30, 2025 11:29

This comment was marked as resolved.

Sign in to view

YuriiMotov added the waiting label Sep 9, 2025

This comment was marked as resolved.

Sign in to view

github-actions Bot removed the waiting label Sep 9, 2025

Add test for field regex/pattern parameter

5de3c0b

stickm4n force-pushed the main branch from 0b9f96f to 5de3c0b Compare September 9, 2025 22:38

This comment was marked as resolved.

Sign in to view

YuriiMotov added feature New feature or request and removed breaking labels Sep 10, 2025

YuriiMotov changed the title 💥 Rename regex to pattern to provide compatibility with Pydantic V2 ✨ Support pattern parameter Sep 10, 2025

Rename tests

570be83

github-actions Bot removed the conflicts Automatically generated when a PR has a merge conflict label Jan 28, 2026

YuriiMotov reviewed Jan 28, 2026

View reviewed changes

Update deprecations to be consistent with other PRs

2b342da

YuriiMotov force-pushed the main branch from c6f4c1c to 2b342da Compare January 28, 2026 17:07

This comment was marked as resolved.

Sign in to view

github-actions Bot added the conflicts Automatically generated when a PR has a merge conflict label Feb 20, 2026

Merge branch 'main' into main

6eda60a

github-actions Bot removed the conflicts Automatically generated when a PR has a merge conflict label Feb 21, 2026

Fix discriminator type annotation

879d4b8

coderabbitai Bot mentioned this pull request Mar 18, 2026

feat: Implement User, Role and Permission Models cschwartz/verdict#32

Merged

This comment was marked as resolved.

Sign in to view

github-actions Bot added the conflicts Automatically generated when a PR has a merge conflict label Apr 3, 2026

Merge branch 'main' into main

7ecd621

github-actions Bot removed the conflicts Automatically generated when a PR has a merge conflict label Apr 3, 2026

YuriiMotov reviewed Apr 3, 2026

View reviewed changes

Comment thread sqlmodel/main.py Outdated

Update type hints for regex and pattern parameters to support `re.Pat…

1acc4b9

…tern`

stickm4n requested a review from YuriiMotov April 5, 2026 07:39

stickm4n added 2 commits April 5, 2026 09:49

Remove support for re.Pattern in regex parameter type hints

98a52b1

Add re import in main.py

cfc88f3

stickm4n commented Apr 5, 2026

View reviewed changes

Comment thread sqlmodel/main.py

apiwat-chantawibul mentioned this pull request Jun 2, 2026

create basic data model for testssl scan result. nectec-pqc/tls-security-monitoring#6

Open

Merge branch 'fastapi:main' into main

f7f9b5f

YuriiMotov approved these changes Jul 15, 2026

View reviewed changes

github-actions Bot added the conflicts Automatically generated when a PR has a merge conflict label Aug 28, 2026

This comment was marked as resolved.

Sign in to view

Merge branch 'main' into main

bc43eb7

github-actions Bot removed the conflicts Automatically generated when a PR has a merge conflict label Sep 1, 2026

🎨 Auto format

54d0764

✨ Support `pattern` parameter by stickm4n · Pull Request #1231 · fastapi/sqlmodel · GitHub

Repository navigation

✨ Support pattern parameter - #1231

✨ Support pattern parameter#1231stickm4n wants to merge 24 commits intofastapi:mainfastapi/sqlmodel:mainfrom stickm4n:mainstickm4n/sqlmodel:mainCopy head branch name to clipboard

Conversation

stickm4n commented Dec 1, 2024 • edited by YuriiMotov Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stickm4n commented Dec 11, 2024

Uh oh!

svlandeg commented Feb 20, 2025

Uh oh!

stickm4n commented Feb 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

YuriiMotov left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as resolved.

This comment was marked as resolved.

Uh oh!

stickm4n left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Graphity commented Jun 21, 2026

Uh oh!

YuriiMotov left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as resolved.

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

✨ Support pattern parameter#1231
stickm4n wants to merge 24 commits into
fastapi:mainfrom
stickm4n:main

stickm4n commented Dec 1, 2024 •
edited by YuriiMotov
Loading

stickm4n commented Feb 22, 2025 •
edited
Loading