FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

👷 Fix py3.7 tests, use ubuntu-22.04 for test jobs by ryangalamb · Pull Request #1276 · fastapi/sqlmodel · GitHub

  1. fastapi
  2. sqlmodel

Repository navigation

👷 Fix py3.7 tests, use ubuntu-22.04 for test jobs - #1276

Closed
ryangalamb wants to merge 1 commit into
fastapi:mainfrom
ryangalamb:rjmill/fix-pipeline
ConversationCommits (1)ChecksFiles changed
Closed

👷 Fix py3.7 tests, use ubuntu-22.04 for test jobs#1276
ryangalamb wants to merge 1 commit into
fastapi:mainfrom
ryangalamb:rjmill/fix-pipeline

Conversation

ryangalamb commented Jan 24, 2025

Copy link
Copy Markdown

More info in this thread: actions/setup-python#962

Announcement for moving ubuntu-latest to 24.04: actions/runner-images#10636
It says that the setup-python action should be able to install 3.7, but the discussion in actions/setup-python#962 (and the failing pipelines in this repo) say otherwise.

github-actions Bot added the internal Internal changes label Jan 24, 2025
ryangalamb mentioned this pull request Jan 24, 2025
Open
ryangalamb changed the title ci: use ubuntu-22.04 for jobs that need py 3.7 👷 Fix py3.7 tests, use ubuntu-22.04 for test jobs Jan 28, 2025

AlanBogarin commented Feb 3, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Currently most pulls fail tests due to this issue with 3.7

PaleNeutron mentioned this pull request Feb 14, 2025
Open

dolfandringa commented Feb 19, 2025 •
edited
Loading

Copy link
Copy Markdown

@ryangalamb Would it be possible to merge this, so #1226 can be unblocked?

ryangalamb commented Feb 19, 2025

Copy link
Copy Markdown
Author

I don't have the ability to merge.

@tiangolo when you get a chance, could you please take a look at this? All CI pipelines are failing without this fix 🙏

svlandeg reviewed Feb 20, 2025
View reviewed changes

svlandeg left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Hi @ryangalamb,

I totally missed this PR, sorry!

I've actually been wanting to upgrade the test suite further to also test on different OS's, see #1290. Only I've been running into time-out issues with smokeshow 😭
But I'm looking into this and will sort things out. In the meantime, testing on Python 3.7 has been temporarily disabled.

This PR would have definitely been a good quick fix though, I'm sorry I didn't see it sooner. Thanks for contributing! Really appreciate it. I'll go ahead and close this now, but I'll continue working on getting the CI in a proper state again.

In the meantime, at least other PRs should go greeen again with 3.7 temporarily disabled (though admittedly not ideal).

svlandeg closed this Feb 20, 2025

svlandeg commented Feb 24, 2025

Copy link
Copy Markdown
Member

Now fixed with #1309

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

svlandeg svlandeg left review comments
+1 more reviewer
adsharma adsharma approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

internal Internal changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL