Repository navigation
馃挌 Fix CI test suite for Windows and MacOS - #1307
Merged
tiangolo merged 19 commits intoSep 17, 2025
Merged
tiangolo merged 19 commits into
tiangolo merged 19 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
svlandeg
commented
Apr 28, 2025
Comment thread
pyproject.toml
| ] | ||
| context = '${CONTEXT}' | ||
| dynamic_context = "test_function" | ||
| relative_files = true |
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
The coverage test kept on giving this error for either MacOS or Windows:
No source for code: '/Users/runner/work/sqlmodel/sqlmodel/docs_src/__init__.py'.
This is fixed by using the relative_files setting 馃帀
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
svlandeg
commented
Sep 17, 2025
Comment thread
tests/test_select_gen.py
Outdated
This comment was marked as outdated.
Copy link
Copy Markdown
Contributor
|
馃摑 Docs preview for commit efebba6 at: https://0a7e396a.sqlmodel.pages.dev |
Sorry, something went wrong.
tiangolo
approved these changes
Sep 17, 2025
tiangolo
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Niceee! Thank you! 馃檶 馃殌
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run the test suite not only on Ubuntu, but also on Windows and MacOS.
To avoid getting an exponential number of tests, limiting the testing of older Python versions to just a few different combinations. All in all, now the test suite should have 12 combinations to test (3x1x2 + 6), which is the same as before (6x2x1). So it shouldn't be slower, but it should cover more diverse cases.