| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
Thanks @RobertRosca! SQLAlchemy only allows types in the sequential arguments, not in keyword arguments. So it would have been in sa_column_args. But still, probably more control in sa_column. Either way, there's now support for sa_type which should simplify it: #505 That will be available in 0.0.11. 🎉 Given that, I'll close this one, thanks for the effort! ☕ |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
In #156 @phi-friday wanted to pass sa_column_kwargs={"type_": Unicode} to a Field to set the column to nvarchar, doing this causes an exception:
sa_type is passed by get_column_from_field as a positional argument, so passing it through at a kwarg leads to this exception.
PR checks if type_ is in the kwargs, and if it is it pops it from the kwargs and sets sa_type to its value.
Also added a test for this case, @tiangolo is issue-related tests in a separate directory a thing you like? It's not done in FastAPI or here, so if not I'll move it.
Edit: whoops, forgot the sa_column argument existed, given that this seems kind of pointless 🤔