FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

✅ Remove unused type ignores since SQLAlchemy 2.0.44 by svlandeg · Pull Request #1613 · fastapi/sqlmodel · GitHub

Repository navigation

✅ Remove unused type ignores since SQLAlchemy 2.0.44 - #1613

Merged
tiangolo merged 1 commit into
fastapi:mainfrom
svlandeg:fix/unused_ignores
Oct 21, 2025
Merged

tiangolo merged 1 commit into
fastapi:mainfrom
svlandeg:fix/unused_ignores

Conversation

Copy link
Copy Markdown
Member

Since SQLAlchemy 2.0.44, we can remove two unnecessary type: ignore statements. If we don't remove them, mypy will fail our CI with

sqlmodel/orm/session.py:116: error: Unused "type: ignore" comment  [unused-ignore]
sqlmodel/ext/asyncio/session.py:132: error: Unused "type: ignore" comment  [unused-ignore]
Found 2 errors in 2 files

svlandeg added the internal Internal changes label Oct 21, 2025

tiangolo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nice!

tiangolo merged commit 95c6b2d into fastapi:main Oct 21, 2025
27 checks passed
svlandeg deleted the fix/unused_ignores branch October 21, 2025 09:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Internal changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL