FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

✨ Add support for PEP695 `type` alias syntax by stickm4n · Pull Request #1628 · fastapi/sqlmodel · GitHub

  1. fastapi
  2. sqlmodel

Repository navigation

✨ Add support for PEP695 type alias syntax - #1628

Open
stickm4n wants to merge 23 commits into
fastapi:mainfrom
stickm4n:type-alias-fix
ConversationCommits (23)ChecksFiles changed
Open

✨ Add support for PEP695 type alias syntax#1628
stickm4n wants to merge 23 commits into
fastapi:mainfrom
stickm4n:type-alias-fix

Conversation

stickm4n commented Oct 28, 2025

Copy link
Copy Markdown
Contributor

As a language feature for Python 3.12+ was introduced new type-alias definitions.
Reference here

They are not working in sqlmodel hence this PR to support them.

stickm4n commented Oct 28, 2025

Copy link
Copy Markdown
Contributor Author

@YuriiMotov could you review this and label it?

stickm4n commented Oct 29, 2025
View reviewed changes
Comment thread tests/test_field_sa_type.py Outdated
YuriiMotov changed the title Type alias for Python 3.12+ is not working ✨ Add support for PEP695 type alias syntax Oct 29, 2025
YuriiMotov added the feature New feature or request label Oct 29, 2025
stickm4n mentioned this pull request Oct 29, 2025
Merged
YuriiMotov marked this pull request as draft October 29, 2025 11:40

This comment was marked as resolved.

Sign in to view
stickm4n commented Oct 29, 2025
View reviewed changes
Comment thread tests/test_field_sa_type.py Outdated
stickm4n marked this pull request as ready for review October 29, 2025 12:16

YuriiMotov commented Oct 30, 2025

Copy link
Copy Markdown
Member

Could you please comment on the implementation of the algorithm?
Also, looks like the title and description of PR don't match the changes.
We should either split changes into several PRs (probably preferrable) or update title\description

stickm4n commented Oct 30, 2025

Copy link
Copy Markdown
Contributor Author

Could you please comment on the implementation of the algorithm?

Also, looks like the title and description of PR don't match the changes.

We should either split changes into several PRs (probably preferrable) or update title\description

Ok, it's a good idea.
I will document the changes referencing all PEPs that are supported with this.
When I was implementing it I noticed there were more type definitions that were not covered.
I thinks it's all type definitions, which are different from alias by variable assignment.

stickm4n commented Oct 30, 2025

Copy link
Copy Markdown
Contributor Author

@svlandeg could you please take a look at this?

github-actions Bot added the conflicts Automatically generated when a PR has a merge conflict label Apr 3, 2026

This comment was marked as resolved.

Sign in to view
github-actions Bot removed the conflicts Automatically generated when a PR has a merge conflict label Apr 5, 2026

github-actions Bot commented Apr 5, 2026

Copy link
Copy Markdown
Contributor

This pull request has a merge conflict that needs to be resolved.

github-actions Bot added the conflicts Automatically generated when a PR has a merge conflict label Apr 5, 2026

This branch has not been deployed

No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

YuriiMotov YuriiMotov left review comments

Assignees

No one assigned

Labels

conflicts Automatically generated when a PR has a merge conflict feature New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL