Repository navigation
馃摑 Fix ambiguous phrasing regarding HeroPublicWithTeam model - #1678
Merged
svlandeg merged 5 commits intoMar 9, 2026
Merged
svlandeg merged 5 commits into
svlandeg merged 5 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
馃摑 Docs previewLast commit 33f02a1 at: https://822f6777.sqlmodel.pages.dev Modified Pages |
Sorry, something went wrong.
YuriiMotov
approved these changes
Dec 24, 2025
YuriiMotov
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
@berkaykrc, thanks!
I agree this way it reads a bit easier.
We can also update the paragraph above:
- Now, notice that these new fields `team` and `heroes` are not declared with `Relationship()`, because these are not **table models**, they cannot have **relationship attributes** with the magic access to get that data from the database.
+ Now, notice that these new fields `team` and `heroes` are not declared with `Relationship()`, because `HeroPublicWithTeam` and `TeamPublicWithHeroes` are not **table models**, they cannot have **relationship attributes** with the magic access to get that data from the database.("these" replaced with explicit "HeroPublicWithTeam and TeamPublicWithHeroes")
Sorry, something went wrong.
svlandeg
approved these changes
Mar 9, 2026
svlandeg
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks @berkaykrc! I also applied @YuriiMotov's suggestion, to make both these paragraphs crystal clear 馃帀
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I noticed a sentence in the Models with Relationships section that was slightly ambiguous and caused confusion about which model was being described.
In the paragraph discussing recursion, the text says:
Because the sentence omits the subject (the HeroPublicWithTeam class), it reads as if the text is describing a field inside TeamPublicWithHeroes, rather than explaining how the team field is typed inside the Hero model.
Changes
I have updated the text to explicitly state that we are looking at the HeroPublicWithTeam model.
Example of clarification:
This small change reduces cognitive load and prevents readers from looking for a logic error in TeamPublicWithHeroes.