FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

🏷️ Fix typing for `exclude` parameter of `Field`, deprecate `include` parameter by YuriiMotov · Pull Request #1724 · fastapi/sqlmodel · GitHub

  1. fastapi
  2. sqlmodel

Repository navigation

🏷️ Fix typing for exclude parameter of Field, deprecate include parameter #1724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
YuriiMotov wants to merge 9 commits into
base: main
Choose a base branch
Could not load branches
Branch not found: {{ refName }}

Are you sure you want to change the base?

Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
from
+46 −8
Conversation 6 Commits 9 Checks 26 Files changed 2
Open

🏷️ Fix typing for exclude parameter of Field, deprecate include parameter #1724

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2863b52
Update type annotation of `exclude` parameter to `Field`
YuriiMotov Jan 28, 2026
b2c1f53
Add test for Field `exclude` parameter
YuriiMotov Jan 28, 2026
f46fc69
Remove outdated `include` parameter from `Field`
YuriiMotov Jan 28, 2026
8467dff
Revert "Remove outdated `include` parameter from `Field`"
YuriiMotov Feb 3, 2026
b1f6ff1
Deprecate `include`parameter of `Field`
YuriiMotov Feb 3, 2026
bd8e3b8
🎨 Auto format
github-actions[bot] Feb 3, 2026
5a45aea
Merge branch 'main' into fix-field-exclude-parameter-typing
YuriiMotov Feb 20, 2026
2104bf5
Merge branch 'main' into fix-field-exclude-parameter-typing
YuriiMotov Apr 3, 2026
e321b5a
Merge branch 'main' into fix-field-exclude-parameter-typing
YuriiMotov Aug 28, 2026
File filter

Filter by extension

Filter by extension .py  (2) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
31 changes: 23 additions & 8 deletions sqlmodel/main.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@
)
OnDeleteType = Literal["CASCADE", "SET NULL", "RESTRICT"]

INCLUDE_DEPRECATION_MSG = "`include` is deprecated and does nothing. It will be removed, use `exclude` instead"
MIN_ITEMS_DEPRECATION_MSG = (
"`min_items` is deprecated and will be removed, use `min_length` instead"
)
Expand Down Expand Up @@ -252,8 +253,11 @@ def Field(
serialization_alias: str | None = None,
title: str | None = None,
description: str | None = None,
exclude: Set[int | str] | Mapping[int | str, Any] | Any = None,
include: Set[int | str] | Mapping[int | str, Any] | Any = None,
exclude: bool | None = None,
include: Annotated[
Set[int | str] | Mapping[int | str, Any] | Any,
deprecated(INCLUDE_DEPRECATION_MSG),
] = None,
const: bool | None = None,
gt: float | None = None,
ge: float | None = None,
Expand Down Expand Up @@ -301,8 +305,11 @@ def Field(
serialization_alias: str | None = None,
title: str | None = None,
description: str | None = None,
exclude: Set[int | str] | Mapping[int | str, Any] | Any = None,
include: Set[int | str] | Mapping[int | str, Any] | Any = None,
exclude: bool | None = None,
include: Annotated[
Set[int | str] | Mapping[int | str, Any] | Any,
deprecated(INCLUDE_DEPRECATION_MSG),
] = None,
const: bool | None = None,
gt: float | None = None,
ge: float | None = None,
Expand Down Expand Up @@ -359,8 +366,11 @@ def Field(
serialization_alias: str | None = None,
title: str | None = None,
description: str | None = None,
exclude: Set[int | str] | Mapping[int | str, Any] | Any = None,
include: Set[int | str] | Mapping[int | str, Any] | Any = None,
exclude: bool | None = None,
include: Annotated[
Set[int | str] | Mapping[int | str, Any] | Any,
deprecated(INCLUDE_DEPRECATION_MSG),
] = None,
const: bool | None = None,
gt: float | None = None,
ge: float | None = None,
Expand Down Expand Up @@ -398,8 +408,11 @@ def Field(
serialization_alias: str | None = None,
title: str | None = None,
description: str | None = None,
exclude: Set[int | str] | Mapping[int | str, Any] | Any = None,
include: Set[int | str] | Mapping[int | str, Any] | Any = None,
exclude: bool | None = None,
include: Annotated[
Set[int | str] | Mapping[int | str, Any] | Any,
deprecated(INCLUDE_DEPRECATION_MSG),
] = None,
const: bool | None = None,
gt: float | None = None,
ge: float | None = None,
Expand Down Expand Up @@ -437,6 +450,8 @@ def Field(
) -> Any:
current_schema_extra = schema_extra or {}

if include is not None:
warnings.warn(INCLUDE_DEPRECATION_MSG, DeprecationWarning, stacklevel=2)
if min_items is not None:
warnings.warn(MIN_ITEMS_DEPRECATION_MSG, DeprecationWarning, stacklevel=2)
if min_length is None:
Expand Down
23 changes: 23 additions & 0 deletions tests/test_pydantic/test_field.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,29 @@ class Model(SQLModel):
assert "foo=" not in repr(instance)


def test_exclude():
class Model(SQLModel):
id: int
name: str
value: int = Field(exclude=True)

instance = Model(id=1, name="test", value=42)
dict_representation = instance.model_dump()
assert "id" in dict_representation
assert "name" in dict_representation
assert "value" not in dict_representation


def test_include_is_deprecated():
with pytest.warns(
DeprecationWarning,
match="`include` is deprecated and does nothing. It will be removed, use `exclude` instead",
):

class Model(SQLModel):
values: list[int] = Field(include=True)


def test_min_items():
with pytest.warns(
DeprecationWarning,
Expand Down
Back | FazBrowse Home | New Git URL