It will still work, but emit a deprecation warning.
Actually, these parameters don't currently work master. This PR also fixes this the same way it's done in Pydantic's Field (min_length = min_items)
Code example and its output in the details:
Details
frompydanticimportValidationErrorfromsqlmodelimportField, SQLModelclassModel(SQLModel):
value: list[int] =Field(min_items=2, max_items=4)
# DeprecationWarning: `min_items` is deprecated and will be removed, use `min_length` instead# value: list[int] = Field(min_items=2, max_items=4)# DeprecationWarning: `max_items` is deprecated and will be removed, use `max_length` instead# value: list[int] = Field(min_items=2, max_items=4)try:
a=Model(value=[1])
exceptValidationErrorase:
print(e)
# 1 validation error for Model# value# List should have at least 2 items after validation, not 1 [type=too_short, input_value=[1], input_type=list]# For further information visit https://errors.pydantic.dev/2.12/v/too_shorttry:
b=Model(value=[1, 2, 3, 4, 5])
exceptValidationErrorase:
print(e)
# 1 validation error for Model# value# List should have at most 4 items after validation, not 5 [type=too_long, input_value=[1, 2, 3, 4, 5], input_type=list]# For further information visit https://errors.pydantic.dev/2.12/v/too_long
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
min_items and max_items parameters of Field are deprecated in Pydantyc V2
This PR reflects this in sqlmodel's Field.
It will still work, but emit a deprecation warning.
Actually, these parameters don't currently work master. This PR also fixes this the same way it's done in Pydantic's Field (min_length = min_items)
Code example and its output in the details:
Details