FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

馃悰 Fix type annotation in `SQLModel.__new__`, avoid explicitly returning `Any` by carljm 路 Pull Request #1846 路 fastapi/sqlmodel 路 GitHub

  1. fastapi
  2. sqlmodel

Repository navigation

馃悰 Fix type annotation in SQLModel.__new__, avoid explicitly returning Any #1846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tiangolo merged 1 commit into from
Apr 2, 2026
Conversation 2 Commits 1 Checks 24 Files changed
Merged

馃悰 Fix type annotation in SQLModel.__new__, avoid explicitly returning Any #1846

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .py  (1) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
4 changes: 3 additions & 1 deletion sqlmodel/main.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -814,7 +814,9 @@ class SQLModel(BaseModel, metaclass=SQLModelMetaclass, registry=default_registry
__allow_unmapped__ = True # https://docs.sqlalchemy.org/en/20/changelog/migration_20.html#migration-20-step-six
model_config = SQLModelConfig(from_attributes=True)

def __new__(cls, *args: Any, **kwargs: Any) -> Any:
# Typing spec says `__new__` returning `Any` overrides normal constructor
# behavior, but a missing annotation does not:
def __new__(cls, *args: Any, **kwargs: Any): # type: ignore[no-untyped-def]
new_object = super().__new__(cls)
# SQLAlchemy doesn't call __init__ on the base class when querying from DB
# Ref: https://docs.sqlalchemy.org/en/14/orm/constructors.html
Expand Down
Loading
Back | FazBrowse Home | New Git URL