Repository navigation
馃敟 Remove outdated needs_py310 marker from tests - #1852
Merged
svlandeg merged 1 commit intoApr 5, 2026
Merged
svlandeg merged 1 commit into
svlandeg merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@YuriiMotov can you take a look here please? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@stickm4n : please refrain from pinging maintainers directly. These PRs are being triaged but additional pings just add to our workload and effectively slows us down by adding to the noise. |
Sorry, something went wrong.
svlandeg
approved these changes
Apr 5, 2026
svlandeg
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Good catch!
There's a lot of files impacted here, but I reviewed everything in detail and it all looks good, simply removing the needs_py310 marker which has become redundant now that sqlmodel only support Python 3.10 and up.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since February 20th minimum version of python supported by sqlmodel is Python 3.10, therefor this check becomes redundant.