Repository navigation
Fix: preserve relationship annotations during class creation - #1857
Open
aliyevr889 wants to merge 2 commits into
Open
aliyevr889 wants to merge 2 commits into
aliyevr889 wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
…ation preservation Cover three scenarios: 1. Relationship annotations visible in __init_subclass__ hooks 2. Relationship fields excluded from Pydantic model_fields 3. End-to-end relationship functionality still works after the fix Fixes fastapi#530
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #530. This PR ensures that Relationship annotations are preserved in annotations during the class creation phase, allowing init_subclass and other initialization hooks to inspect them.
The fix preserves all original annotations in the metadata passed to the base metaclass, and then cleans up any Pydantic fields automatically created for relationships to avoid validation overhead.