FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix enums converting by deknowny · Pull Request #197 · fastapi/sqlmodel · GitHub

Repository navigation

Fix enums converting - #197

Closed
deknowny wants to merge 2 commits into
fastapi:mainfrom
deknowny:fix-enums
Closed

deknowny wants to merge 2 commits into
fastapi:mainfrom
deknowny:fix-enums

Conversation

Copy link
Copy Markdown

There was a bug with enums because you return enum.Enum instead of sqlalchemy.Enum when resolve an enum field

Copy link
Copy Markdown

duplicate of #165

Copy link
Copy Markdown
Author

oh, okay, but still not merged

Copy link
Copy Markdown
Author

@tiangolo do you know about the problem?

0.0.6 is released without any of these enums fixes

Copy link
Copy Markdown
Member

Thank you @deknowny! 🍰

And thanks everyone for the discussion. ☕

This was solved in #165 that included tests, so I'll close this one. The fix will be available in the next release, SQLModel 0.0.7, in the next hours. 🎉

Thanks for the effort! ☕

tiangolo closed this Aug 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL