Repository navigation
🐛 Fix type of __sqlmodel_relationships__ - #1996
Merged
svlandeg merged 2 commits intoJun 6, 2026
Merged
svlandeg merged 2 commits into
svlandeg merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
I'm a little uncertain about the label here, neither "bug" or "internal" sounds exactly right. |
Sorry, something went wrong.
svlandeg
marked this pull request as ready for review
June 4, 2026 08:54
Copy link
Copy Markdown
Contributor
📝 Docs previewLast commit aba325f at: https://19442360.sqlmodel.pages.dev |
Sorry, something went wrong.
YuriiMotov
approved these changes
Jun 4, 2026
YuriiMotov
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix type of __sqlmodel_relationships__. With the current version of ty it still type checks fine, but if we want to upgrade this will become a warning/error.
This PR shows that the edit works fine for our old version of ty 0.0.35 (first commit) as well as for the new 0.0.40 (second and final commit). This came up in #1995.
AI Disclaimer
AI used for quick diagnostics.
Checklist