Repository navigation
fix typing for data parsing - #27
Closed
kafai-lam wants to merge 3 commits into
Closed
kafai-lam wants to merge 3 commits into
kafai-lam wants to merge 3 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
|
Please see also https://github.com/kafai97/sqlmodel/pull/1 which adds the return type to .from_orm. |
Sorry, something went wrong.
Add correct return type in from_orm
Copy link
Copy Markdown
Author
Sorry, something went wrong.
Copy link
Copy Markdown
|
Indeed! Thanks for pointing that out. Hopefully there will soon be a release. |
Sorry, something went wrong.
synodriver
pushed a commit
to synodriver/sqlmodel
that referenced
this pull request
Jun 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For now, whenever .from_orm or .parse_obj method was called on a SQLModel, it will return SQLModel type only instead of the actually model class.
This PR applies generic TypeVar for those methods to generate a more precise typing.