FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

⬆ Raise SQLAlchemy version requirement to at least `1.4.29` (related to #434) by daniil-berg · Pull Request #439 · fastapi/sqlmodel · GitHub

  1. fastapi
  2. sqlmodel

Repository navigation

⬆ Raise SQLAlchemy version requirement to at least 1.4.29 (related to #434) - #439

Merged
tiangolo merged 3 commits into
fastapi:mainfrom
daniil-berg:inc-sqla-version-req
Oct 23, 2023
ConversationCommits (3)ChecksFiles changed
Merged

⬆ Raise SQLAlchemy version requirement to at least 1.4.29 (related to #434)#439
tiangolo merged 3 commits into
fastapi:mainfrom
daniil-berg:inc-sqla-version-req

Conversation

daniil-berg commented Sep 6, 2022

Copy link
Copy Markdown
Contributor

As @JoshGooch pointed out in #434, SQLAlchemy Session.get only supports the execution_options since version 1.4.29. Support for that parameter was added to SQLModel via #302, but the version requirement is still at >=1.4.17.

codecov Bot commented Sep 6, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ea79c47) 98.49% compared to head (6d170c4) 97.76%.
Report is 62 commits behind head on main.

❗ Current head 6d170c4 differs from pull request most recent head b297bba. Consider uploading reports for the commit b297bba to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #439      +/-   ##
==========================================
- Coverage   98.49%   97.76%   -0.74%     
==========================================
  Files         185      187       +2     
  Lines        5856     6268     +412     
==========================================
+ Hits         5768     6128     +360     
- Misses         88      140      +52

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions Bot commented Sep 6, 2022

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 6d170c4 at: https://631731951693a955e3059257--sqlmodel.netlify.app

github-actions Bot commented Dec 16, 2022

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit c58fafb at: https://639ce0c2f6c06900ababea4c--sqlmodel.netlify.app

antont commented Jun 2, 2023

Copy link
Copy Markdown

we've been happily using 1.4.41 so +1 from here.

tiangolo added the bug Something isn't working label Oct 22, 2023
tiangolo changed the title ⬆ Raise SQLAlchemy version requirement to at least 1.4.29 (fixes #434) ⬆ Raise SQLAlchemy version requirement to at least 1.4.29 (related to #434) Oct 23, 2023

github-actions Bot commented Oct 23, 2023

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit b297bba at: https://450cd5cd.sqlmodel.pages.dev

tiangolo merged commit 9511c46 into fastapi:main Oct 23, 2023

tiangolo commented Oct 23, 2023

Copy link
Copy Markdown
Member

Thank you! This will be available in the next version, 0.0.9. 🎉

tiangolo mentioned this pull request Oct 23, 2023
Closed
8 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL