FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Rephrase the documentation to avoid the word "compromise" and use direct language by lbenitez000 · Pull Request #650 · fastapi/sqlmodel · GitHub

Repository navigation

Rephrase the documentation to avoid the word "compromise" and use direct language - #650

Closed
lbenitez000 wants to merge 3 commits into
fastapi:mainfrom
lbenitez000:doc-compromise-rephrase
Closed

lbenitez000 wants to merge 3 commits into
fastapi:mainfrom
lbenitez000:doc-compromise-rephrase

Conversation

Copy link
Copy Markdown
Contributor

Changed a few words in the documentation to

  1. Use "Have a Contract" instead of "Compromise" as it may be interpreted as "trade-off"
  2. Use "must" and "will" instead of "would" to show that it's a commitment

tiangolo added the docs Improvements or additions to documentation label Oct 22, 2023

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 1d08683 at: https://65bdb805.sqlmodel.pages.dev

Copy link
Copy Markdown
Member

Thank you @lbenitez000! 🚀

I got confused with this PR and thought I couldn't push to your branch to update, but I was using the wrong branch. 🤦

I ended up adding a new PR including your commits here #674

And now I realize that I was looking at the wrong branch.

Anyway, thank you for your help! ☕

tiangolo closed this Oct 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL