FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

✨ Add support for Pydantic v2 (while keeping support for v1 if v2 is not available), including initial work by AntonDeMeester by tiangolo · Pull Request #722 · fastapi/sqlmodel · GitHub

  1. fastapi
  2. sqlmodel

Repository navigation

✨ Add support for Pydantic v2 (while keeping support for v1 if v2 is not available), including initial work by AntonDeMeester - #722

Merged
tiangolo merged 109 commits into
mainfrom
pv2-c
Dec 4, 2023
ConversationCommits (109)ChecksFiles changed
Merged

✨ Add support for Pydantic v2 (while keeping support for v1 if v2 is not available), including initial work by AntonDeMeester#722
tiangolo merged 109 commits into
mainfrom
pv2-c

Conversation

tiangolo commented Dec 4, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

✨ Add support for Pydantic v2 (while keeping support for v1 if v2 is not available)

This includes the commits in the initial work by @AntonDeMeester in #699

  • I reverted some things, refactored some parts, fixed some hidden bugs.
  • Restructured the logic in compat.
  • Updated the methods to be available in both Pydantic v1 and v2.
  • Deprecated old methods (from_orm(), etc), adding deprecation markers (they show up in editors), and refactoring the code to use the new ones.
  • Update the docs to use .model_validate() instead of .from_orm() and .parse_obj().
  • Re-implemented several internal parts to support data updates in .model_validate() and keep compatibility with Pydantic v2 and v1, whichever is installed.
  • Implemented the necessary logic to allow keeping values without defaults without them.
  • Implemented the logic to support SQLAlchemy's custom init overriding while keeping support for non-SQLAlchemy models.
  • Updated all the necessary tests to be compatible with both Pydantic v2 and v1, minimizing the cases where its needed to have separate tests.

farahats9 and others added 30 commits November 13, 2023 10:49
migration to sqlalchemy 2.0
d0ae3e8
fix some linting errors
8a27655
reflecting python 3.6 deprecation in docs and tests
a2b3c14
Update sqlmodel/sql/expression.py
4760dbd 
Co-authored-by: Stefan Borer <stefan.borer@gmail.com>
resolving @sbor23 comments
ad76a88
add the new Subquery class
96e44e5
fix jinja2 template
9e72750
Result expects a type Tuple[_T]
b19a709
Remove unused type ignore
ae369ed
Result seems well enough typed in SqlAlchemy now we can simply shim over
2ff42db
_Select expects a Tuple[Any, ...]
b6bd94f
Use Dict type instead of Mapping for SqlAlchemy compat
1dbce4d
Execution options are not Optional in SA
c2d310e
Another instance of non-optional execution_options
05a1352
Fix Tuple in jinja template as well
bd00a2b
Use ForUpdateArg from sqlalchemy
c65f018
Fix signature for Session.get
4e29e00
formatting and remove unused type
fd85d02
Upgrade to Pydantic 2
d556059 
Change imports
Undefined => PydanticUndefined
Update SQLModelMetaclass and SQLModel __init__ and __new__ functions
Update SQL Alchemy type inference
Formatting
e92a52e
Linting
61d5d8d
Make all tests but fastapi work
cb494b7
Get all tests except for openapi working
f590548
Write for pydantic v1 and v2 compat
7ecbc38
Make pydantic v1 work again
c21ff69
Liniting
254fb13
Linter
ab07514
Move lint to after tests to see tests
4a4161a
Make most tests succeed
e2d4d1f 
Only need to fix OPEN API things I think
🔀 Merge branch 'main' into pv2-b
725c6ac
AntonDeMeester mentioned this pull request Dec 4, 2023
Closed

github-actions Bot commented Dec 4, 2023

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit f1ab6a6 at: https://987b63e3.sqlmodel.pages.dev

github-actions Bot commented Dec 4, 2023

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 5f4d502 at: https://e043601e.sqlmodel.pages.dev

github-actions Bot commented Dec 4, 2023

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit b3fcaf0 at: https://d531680f.sqlmodel.pages.dev

github-actions Bot commented Dec 4, 2023

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit f121b00 at: https://31d1b17d.sqlmodel.pages.dev

tiangolo added the feature New feature or request label Dec 4, 2023
tiangolo marked this pull request as ready for review December 4, 2023 14:41
tiangolo merged commit fa2f178 into main Dec 4, 2023
tiangolo deleted the pv2-c branch December 4, 2023 14:42

CyberFlameGO commented Dec 4, 2023

Copy link
Copy Markdown

Oh sweet!!

Matthieu-LAURENT39 commented Dec 4, 2023

Copy link
Copy Markdown
Contributor

Really amazing news, thanks for all the work that went into this!

lmmx mentioned this pull request Dec 10, 2023
Closed
YuriiMotov mentioned this pull request Aug 7, 2025
Closed
8 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

feature New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL