FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

🐛 Fix `RuntimeError: dictionary changed size during iteration` in `sqlmodel_update()` by BartSchuurmans · Pull Request #997 · fastapi/sqlmodel · GitHub

Repository navigation

🐛 Fix RuntimeError: dictionary changed size during iteration in sqlmodel_update() - #997

Merged
tiangolo merged 3 commits into
fastapi:mainfrom
BartSchuurmans:fix-sqlmodel-update-runtime-error
Dec 23, 2025
Merged

tiangolo merged 3 commits into
fastapi:mainfrom
BartSchuurmans:fix-sqlmodel-update-runtime-error

Conversation

Copy link
Copy Markdown
Contributor

Fixes the issue described in #982

alejsdev added the bug Something isn't working label Jul 12, 2024

birdhackor commented Aug 15, 2024 •
edited
Loading

Copy link
Copy Markdown

@alejsdev

May this PR be merged?

This comment was marked as resolved.

This comment was marked as resolved.

github-actions Bot removed the waiting label Aug 21, 2025
BartSchuurmans force-pushed the fix-sqlmodel-update-runtime-error branch from 83c2be0 to 0ed7c7c Compare August 21, 2025 16:05

Copy link
Copy Markdown
Contributor Author

@YuriiMotov Thanks for your response, I've added (and slightly modified) the test you suggested.

github-actions Bot removed the waiting label Aug 21, 2025

YuriiMotov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

Comment thread tests/test_update.py Outdated
Comment thread tests/test_update.py Outdated
YuriiMotov changed the title Fix "RuntimeError: dictionary changed size during iteration" in sqlmodel_update() 🐛 Fix RuntimeError: dictionary changed size during iteration in sqlmodel_update() Aug 21, 2025

tiangolo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Awesome, thank you @BartSchuurmans! 🙌

And sorry for the delay. 🙈

Thanks for the help @YuriiMotov! 🍰

This makes sense. It will be available in SQLModel 0.0.28, released in the next hours. 🎉

tiangolo merged commit 6cec19c into fastapi:main Dec 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL