Fix TDE Konsole version - #2319
Closed
Mystia-Izakaya wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Fix for TDE Konsole version
CarterLi
reviewed
May 11, 2026
Comment thread
src/detection/terminalshell/terminalshell.c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for TDE Konsole version
Summary
When using fastfetch in TDE (Trinity Desktop Environment) version of Konsole, the terminal version messes up the output of fastfetch and prints something like this:
This is because the output of /opt/trinity/bin/konsole --version is
Changes
To fix this, I changed the fallback behavior of getTerminalVersionKonsole to set the version to the string between "Konsole: " and " ", instead of the old behavior where the first string between whitespaces is returned (in that case "3.5.0\nTDE:" is wrongly set which explains the unexpected newline in the output of FF)
Checklist