FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[fix]: Minor tweak NixOS_small logo by LibereCode · Pull Request #2357 · fastfetch-cli/fastfetch · GitHub

/ fastfetch Public

[fix]: Minor tweak NixOS_small logo - #2357

Merged
CarterLi merged 4 commits into
fastfetch-cli:devfrom
LibereCode:dev
May 30, 2026
ConversationCommits (4)ChecksFiles changed
Merged

[fix]: Minor tweak NixOS_small logo#2357
CarterLi merged 4 commits into
fastfetch-cli:devfrom
LibereCode:dev

Conversation

LibereCode commented May 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

Related issue (required for new logos for new distros)

Closes #

Changes

  • Fixed minor color mistake of the NixOS_small logo
  • Formatted the URL of "build" in the README.md

Screenshots

Checklist

  • I have tested my changes locally.

codacy-production Bot commented May 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

TIP This summary will be updated as you push new changes.

codacy-production Bot reviewed May 30, 2026
View reviewed changes

codacy-production Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Pull Request Overview

The review confirms that the PR is up to standards with no logic, security, or quality issues identified. No blocking issues were found. Acceptance criteria regarding documentation formatting and asset styling appear addressed, though verification is recommended for the logo rendering and link correctness as these are not covered by automated tests.

Test suggestions

  • Verify the NixOS_small ASCII logo renders with color index $3 on the right side instead of $4.
  • Verify the README 'Build from source' link is correctly formatted and points to the Building wiki page.
Prompt proposal for missing tests 
Consider implementing these tests if applicable:
1. Verify the NixOS_small ASCII logo renders with color index $3 on the right side instead of $4.
2. Verify the README 'Build from source' link is correctly formatted and points to the Building wiki page.

TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback

LibereCode changed the title Minor tweak NixOS_small logo [fix]: Minor tweak NixOS_small logo May 30, 2026
CarterLi reviewed May 30, 2026
View reviewed changes
Comment thread README.md Outdated
## Build from source

See the Wiki: https://github.com/fastfetch-cli/fastfetch/wiki/Building
[See the Wiki](https://github.com/fastfetch-cli/fastfetch/wiki/Building)

CarterLi May 30, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Please revert unrelated changes

LibereCode May 30, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Have reverted it now 👍

Revert "[fix]: markdown-link to wiki"
f3e6e7d 
This reverts commit 72f4d11.

"Remove unrelated changes"
CarterLi merged commit f932db7 into fastfetch-cli:dev May 30, 2026
1 check passed
wasdhjklxyz mentioned this pull request Aug 28, 2026
Merged
1 task

wasdhjklxyz commented Aug 28, 2026

Copy link
Copy Markdown

Why are we changing the colors for what seems to be every couple months. I dont wanna update my config just cuz the colors looked weird to you just fork for your personal preferences why do you make us suffer.

now i gotta fix this little bitty mistakes because #2180 made the stupid decicision by not making separate multicolor variants to leave (a more stable after this pr) people like me who liked the 2 colors in the first place.

LibereCode commented Aug 28, 2026

Copy link
Copy Markdown
Contributor Author

Why are we changing the colors for what seems to be every couple months. I dont wanna update my config just cuz the colors looked weird to you just fork for your personal preferences why do you make us suffer.

now i gotta fix this little bitty mistakes because #2180 made the stupid decicision by not making separate multicolor variants to leave (a more stable after this pr) people like me who liked the 2 colors in the first place.

Dude, rude.
Please inspect the diff, and you would see I only changed small parts.
The default will still show only blue and cyan, here I manually changed the colors to make it easier to see the mistake and the fix.

It would've taken less time to inspect the diff than writing your rude comment. So do that instead next time.

LibereCode commented Aug 28, 2026

Copy link
Copy Markdown
Contributor Author

just fork for your personal preferences why do you make us suffer.

Please go ahead, fork it so you don't have to suffer with an objective improvement.

wasdhjklxyz commented Aug 28, 2026

Copy link
Copy Markdown

just fork for your personal preferences why do you make us suffer.

Please go ahead, fork it so you don't have to suffer with an objective improvement.

I did and I'll suffer by having to clean all this bloat I don't use first but I dont think I give enough of a fuck to actually put in the time loll

wasdhjklxyz commented Aug 28, 2026

Copy link
Copy Markdown

Why are we changing the colors for what seems to be every couple months. I dont wanna update my config just cuz the colors looked weird to you just fork for your personal preferences why do you make us suffer.

now i gotta fix this little bitty mistakes because #2180 made the stupid decicision by not making separate multicolor variants to leave (a more stable after this pr) people like me who liked the 2 colors in the first place.

Dude, rude.

Please inspect the diff, and you would see I only changed small parts.

The default will still show only blue and cyan, here I manually changed the colors to make it easier to see the mistake and the fix.

It would've taken less time to inspect the diff than writing your rude comment. So do that instead next time.

I did look at diff before I posted and I sent this for no reason idk why so myb on that. Apologies. #2180 deserved the anger

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

CarterLi CarterLi left review comments
+1 more reviewer
codacy-production[bot] codacy-production[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL