Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
* added small chimera linux logo * Add logo type for Chimera_small --------- Co-authored-by: Weed <weedygmd> Co-authored-by: Carter Li <CarterLi@users.noreply.github.com>
* Logo: add chimera2, parabola2_small, postmarketos2, qubes_small * Logo: add types to chimera2, parabola2_small, postmarketos2, qubes_small, remove "parabola-gnulinux" * Change logo names to use capital letters --------- Co-authored-by: v_v <circlepuller@inbox.lv> Co-authored-by: Carter Li <CarterLi@users.noreply.github.com>
* add support for proxmox backup server detection * Update Proxmox identifiers and pretty names * Simplify Proxmox logo names in p.inc --------- Co-authored-by: Carter Li <CarterLi@users.noreply.github.com>
The detection code is problematic. Let's hide the package count before we can find the root cause.
Copy link
Copy Markdown
Contributor
Not up to standards ⛔🔴 Issues 4 critical · 4 high · 13 medium🟢 Metrics 22 complexity
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull request overview
Release bump to v2.66.0, combining a set of detection fixes/improvements across platforms, internal refactors (strbuf/list/library loading), optional function tracing support, CI workflow updates, and a large logo refresh.
Changes:
- Bump project version to 2.66.0 and update CHANGELOG.md.
- Improve platform detection/perf (WSLg parsing, Proxmox/Astra detection, PowerShell version via registry, media on macOS) and fix GPU detection issues (Linux/Asahi).
- Add an optional ENABLE_TRACER build mode and update CI workflows + logos.
Reviewed changes
Copilot reviewed 74 out of 74 changed files in this pull request and generated 9 comments.
Show a summary per file| File | Description |
|---|---|
| tests/strbuf.c | Adds tests for new/adjusted strbuf growth behavior. |
| src/modules/cpu/cpu.c | Stops printing CPU package count in default output. |
| src/modules/bluetoothradio/bluetoothradio.c | Refactors cleanup into a helper for reuse. |
| src/logo/image/image.c | Adjusts Chafa dynamic library loading logic (Windows vs non-Windows). |
| src/logo/image/im7.c | Adjusts ImageMagick 7 dynamic library loading logic (Windows vs non-Windows). |
| src/logo/image/im6.c | Reformats ImageMagick 6 library loading call. |
| src/logo/ascii/u.inc | Cleans up/normalizes logo alias names for U* distros. |
| src/logo/ascii/s.inc | Cleans up/normalizes SambaBOX logo aliases. |
| src/logo/ascii/r.inc | Cleans up/normalizes Redstar/ROSA logo aliases. |
| src/logo/ascii/q/qubes_small.txt | Adds new Qubes small ASCII logo asset. |
| src/logo/ascii/q.inc | Registers new Qubes small logo. |
| src/logo/ascii/p/postmarketos2.txt | Adds new PostMarketOS2 ASCII logo asset. |
| src/logo/ascii/p/parabola2_small.txt | Adds new Parabola2 small ASCII logo asset. |
| src/logo/ascii/p.inc | Cleans up/normalizes P* logos and adds new logo variants. |
| src/logo/ascii/o.inc | Cleans up/normalizes OpenKylin/OpenMandriva/Oracle logo aliases. |
| src/logo/ascii/l/linuxmint2_small.txt | Adds new LinuxMint2 small ASCII logo asset. |
| src/logo/ascii/l/linuxmint_small.txt | Updates existing Linux Mint small logo art. |
| src/logo/ascii/l.inc | Registers LinuxMint2 small alternate logo. |
| src/logo/ascii/k.inc | Cleans up/normalizes KISS logo aliases. |
| src/logo/ascii/j.inc | Cleans up/normalizes Januslinux logo aliases. |
| src/logo/ascii/g.inc | Cleans up/normalizes Garuda/GoldenDogLinux logo aliases. |
| src/logo/ascii/f/flatcar.txt | Adds new Flatcar ASCII logo asset. |
| src/logo/ascii/f.inc | Registers Flatcar logo and normalizes Filotimo name casing. |
| src/logo/ascii/c/chimera_linux2.txt | Adds new Chimera2 ASCII logo asset. |
| src/logo/ascii/c/chimera_linux_small.txt | Adds new Chimera small ASCII logo asset. |
| src/logo/ascii/c.inc | Adds Chimera variants and cleans up multiple C* logo aliases. |
| src/logo/ascii/a/azurelinux2.txt | Adds new Azure Linux (alt) ASCII logo asset. |
| src/logo/ascii/a/azurelinux.txt | Adds new Azure Linux ASCII logo asset. |
| src/logo/ascii/a.inc | Registers AzureLinux/AzureLinux2 and adjusts Ataraxia naming comment. |
| src/detection/wm/wm_linux.c | Updates WSLg version parsing for newer WSL formats. |
| src/detection/terminalshell/terminalshell.c | Improves Windows PowerShell version detection via registry before spawning shell. |
| src/detection/os/os_linux.c | Improves Proxmox detection, adds Proxmox Backup Server + Astra version formatting. |
| src/detection/media/media_apple.m | Switches macOS “authorized process” helper from Python ctypes to Perl DynaLoader. |
| src/detection/gpu/gpu.h | Renames GPU helper API to reflect expanded behavior. |
| src/detection/gpu/gpu.c | Renames implementation accordingly. |
| src/detection/gpu/gpu_windows.c | Fixes WSL2 GPU detection flow and updates renamed GPU helper call. |
| src/detection/gpu/gpu_linux.c | Fixes path restoration and AMD name query logic; updates renamed GPU helper call. |
| src/detection/gpu/gpu_drm.c | Fixes comments/cleanup, adjusts popcount usage, improves Asahi core counting logic. |
| src/detection/gpu/gpu_bsddrm.c | Removes noisy perror, updates renamed GPU helper call, fixes endif comment. |
| src/detection/gpu/gpu_bsd.c | Updates renamed GPU helper call. |
| src/detection/gpu/gpu_apple.c | Minor cleanup and clarifies precedence in a size computation. |
| src/detection/cpu/cpu_linux.c | Simplifies ARM CPU name aggregation formatting. |
| src/detection/cpu/cpu_apple.c | Clarifies precedence in a size computation. |
| src/common/thread.h | Uses internal NT header on Windows and adds ffThreadGetCurrentId helper. |
| src/common/library.h | Refactors library-load macros and splits load functions into single vs multi. |
| src/common/impl/tracer.c | Adds optional function tracing implementation (ENABLE_TRACER). |
| src/common/impl/library.c | Implements ffLibraryLoadSingle / ffLibraryLoadMulti split. |
| src/common/impl/io_windows.c | Uses fixed-length reservation for Windows file reads. |
| src/common/impl/FFstrbuf.c | Adds formatting constructors + new ensure-free strategy; moves some funcs to header. |
| src/common/impl/FFPlatform_windows.c | Uses SharedUserData for native architecture mapping. |
| src/common/impl/FFlist.c | Moves ffListAdd implementation out of .c (now inline). |
| src/common/FFstrbuf.h | Moves several strbuf functions inline; adds new APIs. |
| src/common/FFlist.h | Makes ffListAdd a static inline and removes external declaration. |
| presets/examples/10.jsonc | Replaces hardcoded icons in keys with {icon} placeholder. |
| debian/changelog.tpl | Adds a new Ubuntu changelog template entry. |
| CMakeLists.txt | Bumps version to 2.66.0 and adds ENABLE_TRACER build option and flags. |
| CHANGELOG.md | Adds release notes for 2.66.0 and minor wording update under 2.65.2. |
| .github/workflows/build-windows-hosts.yml | Updates checkout action to v7. |
| .github/workflows/build-spellcheck.yml | Updates checkout action to v7. |
| .github/workflows/build-solaris-amd64.yml | Updates checkout action to v7. |
| .github/workflows/build-openbsd-amd64.yml | Switches to cross-platform-actions/action + refactors steps; updates checkout/upload-artifact to v7. |
| .github/workflows/build-omnios-amd64.yml | Switches to cross-platform-actions/action + refactors steps; updates checkout/upload-artifact to v7. |
| .github/workflows/build-no-features-test.yml | Updates checkout action to v7. |
| .github/workflows/build-netbsd-amd64.yml | Switches to cross-platform-actions/action + refactors steps; updates checkout/upload-artifact to v7. |
| .github/workflows/build-musl-amd64.yml | Updates checkout action to v7. |
| .github/workflows/build-macos-hosts.yml | Updates checkout action to v7. |
| .github/workflows/build-linux-vms.yml | Updates checkout action to v7. |
| .github/workflows/build-linux-i686.yml | Updates checkout action to v7. |
| .github/workflows/build-linux-hosts.yml | Updates checkout action to v7. |
| .github/workflows/build-linux-armv7l.yml | Updates checkout action to v7. |
| .github/workflows/build-linux-armv6l.yml | Updates checkout action to v7. |
| .github/workflows/build-haiku-amd64.yml | Switches to cross-platform-actions/action + refactors steps; updates checkout/upload-artifact to v7. |
| .github/workflows/build-freebsd-amd64.yml | Switches to cross-platform-actions/action + refactors steps; updates checkout/upload-artifact to v7. |
| .github/workflows/build-dragonfly-amd64.yml | Switches to cross-platform-actions/action + refactors steps; updates checkout/upload-artifact to v7. |
Sorry, something went wrong.
Comment thread
src/common/impl/tracer.c
Outdated
Comment thread
src/common/impl/tracer.c
Comment thread
debian/changelog.tpl
Comment thread
.github/workflows/build-openbsd-amd64.yml
Comment thread
.github/workflows/build-omnios-amd64.yml
Comment thread
.github/workflows/build-netbsd-amd64.yml
Comment thread
.github/workflows/build-haiku-amd64.yml
Comment thread
.github/workflows/build-dragonfly-amd64.yml
Comment thread
.github/workflows/build-freebsd-amd64.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist