TerminalFont (Alacritty): fix font size never being parsed from config - #2501
Merged
CarterLi merged 1 commit intoAug 9, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
The query array gained a third entry in dd30c82 but numQueries stayed at 2, so `size =` was never queried and every Alacritty user silently got the hardcoded 11.25 fallback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
detectAlacritty() passes numQueries = 2 to ffParsePropFileConfigValues(), but fontQueryToml has three entries. { "size =", &fontSize } sits at index 2 and is never queried, so fontSize stays empty and the hardcoded 11.25 fallback is used for every Alacritty user.
Introduced in dd30c82, which added { "family =", &fontFamily } to the middle of the array without bumping the count, and shipped in 2.67.0. It fails silently — the family is still correct and only the size is wrong, so there is no error to notice.
Testing
Fedora 43, Alacritty 0.17.0, ~/.config/alacritty/alacritty.toml:
Both sizes were checked against the actual rendered window, not just the reported string.
Related issue (required for new logos for new distros)
N/A — no existing report; found while investigating #2348.
Changes
Screenshots
No visual changes — the fix only corrects the reported value.
Checklist