FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: generic format function by Uzlopak · Pull Request #135 · fastify/fastify-error · GitHub

  1. fastify
  2. fastify-error

Repository navigation

feat: generic format function - #135

Open
Uzlopak wants to merge 1 commit into
mainfrom
generic-format
ConversationCommits (1)ChecksFiles changed
Open

feat: generic format function#135
Uzlopak wants to merge 1 commit into
mainfrom
generic-format

Conversation

Uzlopak commented Sep 11, 2024

Copy link
Copy Markdown
Contributor

putting this again for discussion

jsumners commented Sep 11, 2024

Copy link
Copy Markdown
Member

What is being put up "again for discussion"?

Eomm reviewed Sep 22, 2024
View reviewed changes

Eomm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This is a perf PR, did you share some result in other issues that I missed?

Uzlopak commented Sep 22, 2024

Copy link
Copy Markdown
Contributor Author

Since the last parameter can be cause fastify error is limitted to the fixed amount of placeholders. As long as we dont use %o and %O placeholders we can generate format functions which are isomorph. On the other hand, we could actually implement a solution to avoid the issue #134.

jsumners commented Sep 23, 2024

Copy link
Copy Markdown
Member

I really don't understand why we would want to get into the business of maintaining a format string interpolator.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Eomm Eomm left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL