FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

support haxe `final` keyword by romamik · Pull Request #2971 · fdorg/flashdevelop · GitHub

  1. fdorg
  2. flashdevelop

Repository navigation

support haxe final keyword - #2971

Open
romamik wants to merge 4 commits into
fdorg:developmentfrom
romamik:final_keyword
ConversationCommits (4)ChecksFiles changed
Open

support haxe final keyword#2971
romamik wants to merge 4 commits into
fdorg:developmentfrom
romamik:final_keyword

Conversation

romamik commented Jan 27, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Support haxe final keyword for variable completion and coloring.
Resolves #2775 and partially resolves #1925 (does not support final as method modifier.)

r.miklashevski and others added 2 commits January 27, 2020 18:18

SlavaRa commented Jan 30, 2020

Copy link
Copy Markdown

@romamik should this work under haxe < 4.0.0?

romamik commented Jan 30, 2020

Copy link
Copy Markdown
Contributor Author

I did not test with older haxe versions. IMHO it should not break anything, but may display final in autocompletion list.

SlavaRa commented Jan 30, 2020

Copy link
Copy Markdown

I did not test with older haxe versions. IMHO it should not break anything, but may display final in autocompletion list.

I would not be so sure without the tests :)
This shouldn't work for versions < 4.0.0

romamik commented Jan 30, 2020

Copy link
Copy Markdown
Contributor Author

Do you mean to enable/disable this code depending on haxe version? Is there some example of how can this be accomplished?

romamik commented Jan 31, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I've added version check. Now final is not shown in completion if haxe version is < 4. Also I've tested with haxe 3.4.7.

Not sure if the way I add/remove/check item existense in features.codeKeywords and features.declKeywords arrays is correct.

SlavaRa commented Mar 27, 2020

Copy link
Copy Markdown

@romamik i'll check and merge today.

SlavaRa self-assigned this Dec 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

SlavaRa

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Haxe4] Auto-indent wrong after final keyword [Haxe4] Support for final keyword

2 participants

Back | FazBrowse Home | New Git URL