[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rafalzydowicz
To complete the pull request process, please assign woop
You can assign the PR to them by writing /assign @woop in a comment when ready.

The full list of commands accepted by this bot can be found here.

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @rafalzydowicz. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rafalzydowicz are you still actively working on this rebase?

@rafalzydowicz are you still actively working on this rebase?

Yes, we are developing against it on our fork, but this PR is ready. The integration tests are failing, but they are failing on the v7 branch in general (unless I'm missing something) and the jupyter build push because the image isn't found. Would you want these all fixed on this branch?

As an aside, considering your active development of spark on master, what is our goal with this PR?

@rafalzydowicz are you still actively working on this rebase?

Yes, we are developing against it on our fork, but this PR is ready. The integration tests are failing, but they are failing on the v7 branch in general (unless I'm missing something) and the jupyter build push because the image isn't found. Would you want these all fixed on this branch?

Ok, well we will need to fix the tests then. Will keep it open for the time being.

As an aside, considering your active development of spark on master, what is our goal with this PR?

Two reasons to get this merged in.

1. It will take a while for 0.7 users to move to the 0.8+ architecture since its fundamentally different, so it makes sense to keep developing on 0.7 for now.
2. The databricks specific functionality that you have here, especially around Delta and SparkSQL, will be useful for the development we will do in 0.9 (when we try and add Delta support). At the start that will be open source only, but we will probably add databricks API support later. You've already done most of the heavy lifting to add that support, even if we dont use the code verbatim.

@woop, docker build is still failing because it can't find images on docker.io. This may be related to a bug with buildkit mentioned at the bottom of https://docs.docker.com/develop/develop-images/build_enhancements/. Can you please have a look?

@woop, docker build is still failing because it can't find images on docker.io. This may be related to a bug with buildkit mentioned at the bottom of https://docs.docker.com/develop/develop-images/build_enhancements/. Can you please have a look?

Thanks @rafalzydowicz. Will take a look as soon as we get through the 0.8 release.

@rafalzydowicz: The following tests failed, say /retest to rerun all failed tests:

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.