Fix release workflow to pass the python version and docker build targets - #2122
Merged
adchia merged 2 commits intoDec 8, 2021
Merged
Fix release workflow to pass the python version and docker build targets#2122adchia merged 2 commits into
adchia merged 2 commits into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
achals
approved these changes
Dec 8, 2021
achals
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
/lgtm
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, adchia The full list of commands accepted by this bot can be found here. The pull request process is described here Details Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing /approve in a comment |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The new pip-tools way of building feast requires a python version to be passed as an argument to the makefile rule. In the release, we were not doing this.
Also the make-build-X-docker image rule had a typo that didn't include the -docker suffix.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: