feat: Go server by ctkhanhly · Pull Request #2339 · feast-dev/feast · GitHub

feat: Go server - #2339

Merged

feast-ci-bot merged 181 commits into

feast-dev:masterfrom

ctkhanhly:go_server

Mar 8, 2022

Commits on Mar 8, 2022

Remove sdk/go

Tsotne Tabidze
authored and
achals
committed
7321fa8
Add interfaces and overall skeleton (incl working protobufs)

Tsotne Tabidze
authored and
achals
committed
3a60926
Wire up FeatureStore & OnlineStore, implement RedisOnlineStore constructor, add tests

Tsotne Tabidze
authored and
achals
committed
438343a
Introduce RepoConfig struct instead of using raw map[string]interface{}

Tsotne Tabidze
authored and
achals
committed
eac86a8
Pass feast project name to RedisOnlineStore

Tsotne Tabidze
authored and
achals
committed
bd17fbf
Add Redis Online Read Test

Willem Pienaar
authored and
achals
committed
43028e4
Implement gRPC server start logic

Tsotne Tabidze
authored and
achals
committed
89dfa97
Update OnlineRead interface

Willem Pienaar
authored and
achals
committed
9665f86
Redis reader with hashing implemented

Willem Pienaar
authored and
achals
committed
649f64e
added implementation for GetOnlineFeatures in featurestore and a simple test

Ly Cao
authored and
achals
committed
04e9f89
Iterate on key building

Willem Pienaar
authored and
achals
committed
32d41fb
Implement gRPC server

Tsotne Tabidze
authored and
achals
committed
01d036e
Fix some warnings

Tsotne Tabidze
authored and
achals
committed
e5f7884
Fix bugs & tests

Tsotne Tabidze
authored and
achals
committed
213a3b5
Implement redis key builder and reader

Willem Pienaar
authored and
achals
committed
568c0e2
Add more TODO comments

Willem Pienaar
authored and
achals
committed
924d42e
Rebuilt protos

Willem Pienaar
authored and
achals
committed
1ded223
Ignore read test

Willem Pienaar
authored and
achals
committed
d47c134
Add more TODO comments

woop
authored and
achals
committed
4841544
Clean up serialize function

woop
authored and
achals
committed
bde31cb
fixed GetOnlineFeatures to so that each EntityKey is a row in the first param of OnlineRead, added values to SerializeValue

Ly Cao
authored and
achals
committed
60d1af8
Remove comment

woop
authored and
achals
committed
9501812
return copy of Features from OnlineStore instead of reusing original copy + add response for OnlineStore

Ly Cao
authored and
achals
committed
0ce2cd1
Delete go/protos directory from git, since it's in .gitignore

Tsotne Tabidze
authored and
achals
committed
719c189
Fix go/server compilation

Tsotne Tabidze
authored and
achals
committed
90a5fb2
Add integration test

woop
authored and
achals
committed
fb186b7
added http json endpoint + add validation for feature names and entity keys for each requested feature view in GetOnlineFeatures

Ly Cao
authored and
achals
committed
79c230e
Call go subprocess from Python

Tsotne Tabidze
authored and
achals
committed
868a358
fixed GetOnlineFeatures bug

Ly Cao
authored and
achals
committed
7c1fdc7
removed grpc-gateway + add go http server on fs.serve()

Ly Cao
authored and
achals
committed
51760f9
experimenting python connector

Ly Cao
authored and
achals
committed
1b4c457
working version of python connector

Ly Cao
authored and
achals
committed
16fb7d3
fixed python connector error + add a script to build plugin binary

Ly Cao
authored and
achals
committed
fd27ee1
added a simple connector config type to RepoConfig in python sdk to support feast alpha enable go_feature_server

Ly Cao
authored and
achals
committed
eac6c07
migrating python's sdk get_online_features and its helper functions

Ly Cao
authored and
achals
committed
19583eb
added redis pipeline + passed go tests, haven't tested feature service

Ly Cao
authored and
achals
committed
23ddda1
added integration test w/o odfv + dummy entity

Ly Cao
authored and
achals
committed
90b8ae8
accidentally removed entity from request

Ly Cao
authored and
achals
committed
334eb52
passed integration test

Ly Cao
authored and
achals
committed
74e39b6
first go server clean version, keep python functions. Next commit will diverge from python function calls for more optimized calls

Ly Cao
authored and
achals
committed
e024cb3
added 'optimized' functions

Ly Cao
authored and
achals
committed
6887787
added goroutines to OnlineRead

Ly Cao
authored and
achals
committed
a77a73b
added goroutines to redis OnlineRead, getFeaturesToUse, getEntityMaps and entity struct

Ly Cao
authored and
achals
committed
b416af5
Ensure the correct tests are run for the go feature server

felixwang9817
authored and
achals
committed
467beb2
Format and lint

felixwang9817
authored and
achals
committed
9f3b207
Remove Go feature server implementation of Python feature server

felixwang9817
authored and
achals
committed
4343609
Remove incorrect comments

felixwang9817
authored and
achals
committed
6a3dd68
Clean up Go feature server test logic

felixwang9817
authored and
achals
committed
afc33cf
Add docstrings for GoServer class

felixwang9817
authored and
achals
committed
6720d83
Remove unused GoServerError

felixwang9817
authored and
achals
committed
2c7db84
Remove unused ConnectorOnlineStore

felixwang9817
authored and
achals
committed
208db63
Run Go feature server tests separately from main integration tests

felixwang9817
authored and
achals
committed
a6fdd6d
lint-go + cleaned go code + handle BrokenPipeError in go_server.py

Ly Cao
authored and
achals
committed
a4752a1
added create ./go/protos to compile-protos-go in Makefile

Ly Cao
authored and
achals
committed
91b7af4
removed 1 unneeded comment

Ly Cao
authored and
achals
committed
1b91083
fix small bug in go_server raise if error is not brokenpipe in stop function

Ly Cao
authored and
achals
committed
00ce5a6
Add Snowflake back in for Go feature server tests

felixwang9817
authored and
achals
committed
27c798c
formatted go

Ly Cao
authored and
achals
committed
0682aab
Add CI for Go integration tests

felixwang9817
authored and
achals
committed
5c196eb
Modify setup.py to build Go protos and clean up Makefile

felixwang9817
authored and
achals
committed
7812632
Move go build logic to a different file to not trigger on pip install

felixwang9817
authored and
achals
committed
dc6b9fc
Fix Go protoc command

felixwang9817
authored and
achals
committed
c3ee7c1
separated create config from json and yaml + changed go server _connect method name + add TODO to user proper logging + fix go_server exception on stop() + change go layout

Ly Cao
authored and
achals
committed
0a92efc
added go server lifecycle test + local infra for go server + experiment with new go server implementations

Ly Cao
authored and
achals
committed
09440bb
Only run Go tests on FileSource

felixwang9817
authored and
achals
committed
7b1b431
Fix Makefile commands

felixwang9817
authored and
achals
committed
909af37
fixed test to use go_feature_server flag in test + added option to 2 go server implementations + fix parsedKind

Ly Cao
authored and
achals
committed
a1a9c2b
fixed goserverlifecyle test implementation

Ly Cao
authored and
achals
committed
e1a15a6
fixed goserverlifecycle --- still need to review this test

Ly Cao
authored and
achals
committed
63ed132
added a command to test goserver with thread, works in reasonable time now but need to review go server thread implementation

Ly Cao
authored and
achals
committed
0f877b5
Print output

felixwang9817
authored and
achals
committed
36fe4f2
Clean up Makefile and fix errors in setup.py

felixwang9817
authored and
achals
committed
f87742d
Pin Golang protobuf dependency to specific version

felixwang9817
authored and
achals
committed
40f3b35
Format + lint

felixwang9817
authored and
achals
committed
e7536f2
Revert previous change

felixwang9817
authored and
achals
committed
152fa38
Add back Python version

felixwang9817
authored and
achals
committed
b751ac9
Fix test errors due to rebase

felixwang9817
authored and
achals
committed
add4836
Add Go version to unit test workflow

felixwang9817
authored and
achals
committed
a0261d9
Fix .gitignore

felixwang9817
authored and
achals
committed
cff4a5c
Format + lint

felixwang9817
authored and
achals
committed
82903d6
Add setup Go action to set correct Go version for unit tests

felixwang9817
authored and
achals
committed
dd656d9
Test Gopath in workflow

felixwang9817
authored and
achals
committed
dbe2a04
Add Github action for installing protoc during unit tests

felixwang9817
authored and
achals
committed
8154126
Print stderr for Go proto generation

felixwang9817
authored and
achals
committed
0417590
Check for PATH and GOBIN in unit tests

felixwang9817
authored and
achals
committed
af36ce0
Lint

felixwang9817
authored and
achals
committed
0c1499a
Switch from using protoc binary for Go protos to grpcio-tools

felixwang9817
authored and
achals
committed
24bd9b0
Add psutil==5.9.0 dependency for test_go_server_life_cycle test

felixwang9817
authored and
achals
committed
dd3b22c
Specify Go version during Github actions

felixwang9817
authored and
achals
committed
657db6f
Add back protoc setup Github action

felixwang9817
authored and
achals
committed
092341d
Add GOPATH to GITHUB_PATH so that protoc-gen-go is discovered

felixwang9817
authored and
achals
committed
cfe59e7
Set PATH so that protoc-gen-go can be found

felixwang9817
authored and
achals
committed
8c86bc4
Update Python3.7 ci-requirements file

felixwang9817
authored and
achals
committed
08f6332
Update all requirements

felixwang9817
authored and
achals
committed
ee2015f
Fix test

felixwang9817
authored and
achals
committed
90642b7
Fix protoc-gen-go bug for all workflows

felixwang9817
authored and
achals
committed
d698d86
Clean up existing test and mark new test as integration

felixwang9817
authored and
achals
committed
00364c6
Lint

felixwang9817
authored and
achals
committed
4e721ee
Correctly set GOPATH in workflows

felixwang9817
authored and
achals
committed
5eaeebc
Modify AWS Lambda Dockerfile to copy the necessary Go files

felixwang9817
authored and
achals
committed
e16551c
merge infra package into feast package

Ly Cao
authored and
achals
committed
33c5893
optimized go server + address some PR comments

Ly Cao
authored and
achals
committed
2495cfb
added newServingServiceServer to comply with the rest of the code style

Ly Cao
authored and
achals
committed
3219f71
removed an extra err check

Ly Cao
authored and
achals
committed
536cef9
added pre-allocation to online response metadata

Ly Cao
authored and
achals
committed
5de88d9
Fix protoc compilation for go and use a unix domain socket file
achals
committed
05e3599
Use a flag for compilation
achals
committed
342d233
Change flag in
achals
committed
c4de236
fix: Remove redis service to prevent more conflicts and add redis node to master_only (#2354)

kevjumba
authored and
achals
committed
10d96fc
fix: Added additional value types to UI parser and removed references to registry-bq.json (#2361)

authored and
achals
committed
5fe123b
fix:revert back to jdk 11 for datatypes package

adchia
authored and
achals
committed
3caf798
fix:upgrade feast ui packages to fix critical vulnerabilities

adchia
authored and
achals
committed
c8e28ff
ci: Add support for semantic release (#2332)

woop
authored and
achals
committed
a15e947
feat: Allow all snowflake python connector connection methods to be available to Feast (#2356)

sfc-gh-madkins
authored and
achals
committed
d7d9d78
fix: Fix Redshift bug that stops waiting on statements after 5 minutes (#2363)

Tsotne Tabidze
authored and
achals
committed
c3a3add
feat: Feast Spark Offline Store (#2349)

authored and
achals
committed
80f7f62
ci: Update versions of helm charts + java pom files

adchia
authored and
achals
committed
f5597cf
feat: Event timestamps response (#2355)

Vitaly Sergeyev
authored and
achals
committed
f6fc65a
feat: Metadata changes & making data sources top level objects to power Feast UI (#2336)

adchia
authored and
achals
committed
9ae882e
ci: Remove buggy branch identification

woop
authored and
achals
committed
e924b07
fix action and set go version
achals
committed
e2f4ed6
Complie python protos correctly
achals
committed
0576dd4
Set up go in the pr integration test workflow
achals
committed
c50b9ca
Nuke go requirements for python ci (for the moment)
achals
committed
0ce43bd
Update redis port
achals
committed
05276b5
ci: Add version bump script

woop
authored and
achals
committed
f551e6a
ci: Fix broken release preparation

woop
authored and
achals
committed
6407a16
ci: Add ci bot as committer and fix typo in dry-run config

feast-ci-bot
authored and
achals
committed
a9cc1cd
chore(release): release 0.19.0

feast-ci-bot
authored and
achals
committed
39c4de5
chore: Fix changelog and disable release comments

woop
authored and
achals
committed
3f23a40
fix: Fix unhashable Snowflake and Redshift sources

woop
authored and
achals
committed
a07bcf2
chore: Remove needs-kind and release not requirement

woop
authored and
achals
committed
65ac647
chore: Remove release note block

woop
authored and
achals
committed
4a21aaf
ci: Uncheck prerelease status for patch releases

woop
authored and
achals
committed
73c89a3
fix: Fix default feast apply path without any extras (#2373)

adchia
authored and
achals
committed
4204e2f
docs: Add short section about github actions (#2315)

kevjumba
authored and
achals
committed
f4cea5d
fix: Use the correct dockerhub image tag when building feature servers (#2372)
achals
committed
1937021
compile go as part of python ci setup
achals
committed
07bccc9
set path with gopath/bin
achals
committed
89bc3f3
Set path for commands correctly
achals
committed
f52117e
Set up go for lint-go
achals
committed
1097699
Remove makefile stuff
achals
committed
8207017
Fix workflows and Makefile commands
achals
committed
c777979
protoc-gen-go-grpc
achals
committed
b3acdb0
install go deps first
achals
committed
95c6e1d
Compile go protos as well
achals
committed
cc927fd
Remove go mod tidy from the deps target
achals
committed
c0ba7b5
Better python tooling
achals
committed
41889f0
Remove container
achals
committed
c87728f
Upgrade lint go as well
achals
committed
3a1efa3
Upgrade lint go as well
achals
committed
79166ca
More logging for unit-go
achals
committed
0cdfd0b
Install using python setup.py develop
achals
committed
3fa7bc3
install-python-ci-dependencies
achals
committed
8a71886
Skip tests that need a feature repo
achals
committed
1eb0dad
Skip a scary forking test
achals
committed
4323027
Remove all the crusty port stuff and disable the lifecycle test
achals
committed
c1afb01
Remove more crusty port stuff
achals
committed
d6e1b42
Update skip message
achals
committed
709f8bf
Introduce a sleep before reading values
achals
committed
b57616b
Disable one more test configuration since background thread-based monitoring doesn't currently work
achals
committed
db3dc44
Disable the test entirely
achals
committed
8975ac2
ci: Add support for semantic release (#2332)

woop
authored and
achals
committed
7e85d6c
feat: Feast Spark Offline Store (#2349)

authored and
achals
committed
12aafc2
ci: Update versions of helm charts + java pom files

adchia
authored and
achals
committed
22a611e
feat: Metadata changes & making data sources top level objects to power Feast UI (#2336)

adchia
authored and
achals
committed
ffb7e74
ci: Remove buggy branch identification

woop
authored and
achals
committed
833305e
ci: Add version bump script

woop
authored and
achals
committed
1c90492
ci: Fix broken release preparation

woop
authored and
achals
committed
53b8f90
ci: Add ci bot as committer and fix typo in dry-run config

feast-ci-bot
authored and
achals
committed
df7a43e
chore(release): release 0.19.0

feast-ci-bot
authored and
achals
committed
07fdcc7
chore: Fix changelog and disable release comments

woop
authored and
achals
committed
985eaf1
ci: Uncheck prerelease status for patch releases

woop
authored and
achals
committed
09a5cd9
fix: Fix default feast apply path without any extras (#2373)

adchia
authored and
achals
committed
a75bfad
fix: Making a name for data sources not a breaking change (#2379)

adchia
authored and
achals
committed
b54c31a
fix: Update some fields optional in UI parser (#2380)

authored and
achals
committed
d7710c0
fix: Fix spark docs (#2382)

authored and
achals
committed
55c3e87
feat: Makefile for contrib for Issue #2364 (#2366)

authored and
achals
committed
f173a1a
Closes threadpool resources upon datastore online_write_batch completion (#2386)

ptoman-pa
authored and
achals
committed
1c92201
CR comments
achals
committed
481b8dd
Merge from master again
achals
committed
8f3b96a

feat: Go server by ctkhanhly · Pull Request #2339 · feast-dev/feast · GitHub

Navigation Menu

Uh oh!

feat: Go server - #2339

feat: Go server#2339feast-ci-bot merged 181 commits intofeast-dev:masterfeast-dev/feast:masterfrom ctkhanhly:go_serverctkhanhly/feast:go_serverCopy head branch name to clipboard

Commits

Commits on Mar 8, 2022

feat: Go server#2339
feast-ci-bot merged 181 commits into
feast-dev:masterfrom
ctkhanhly:go_server