FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

ci: Reintroduce redis services at 6379 by achals · Pull Request #2395 · feast-dev/feast · GitHub

/ feast Public

ci: Reintroduce redis services at 6379 - #2395

Merged
feast-ci-bot merged 1 commit into
feast-dev:masterfrom
achals:achal/reintro-redis
Mar 10, 2022
ConversationCommits (1)ChecksFiles changed
Merged

ci: Reintroduce redis services at 6379#2395
feast-ci-bot merged 1 commit into
feast-dev:masterfrom
achals:achal/reintro-redis

Conversation

achals commented Mar 10, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Signed-off-by: Achal Shah achals@gmail.com

What this PR does / why we need it:
We moved this to a github action in #2350 and #2354 but this change wasn't needed. I'd like to move the tests back to using the standard redis port so that the tests can be run while developing locally without any changes.

Corresponding test changes to use this redis instance and remove the old one will be in a followup PR.

Which issue(s) this PR fixes:

Fixes #

achals requested a review from a team as a code owner March 10, 2022 18:33
achals requested review from adchia and removed request for a team March 10, 2022 18:33

codecov-commenter commented Mar 10, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #2395 (85a4074) into master (ae133fd) will decrease coverage by 1.57%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2395      +/-   ##
==========================================
- Coverage   84.43%   82.86%   -1.58%     
==========================================
  Files         122      122              
  Lines       10732    11493     +761     
==========================================
+ Hits         9062     9524     +462     
- Misses       1670     1969     +299
Flag Coverage Δ
integrationtests 75.46% <ø> (+0.97%) ⬆️
unittests 56.51% <ø> (-0.49%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../integration/online_store/test_universal_online.py 65.30% <0.00%> (-17.47%) ⬇️
...ts/integration/feature_repos/repo_configuration.py 80.84% <0.00%> (-15.22%) ⬇️
sdk/python/feast/feature_store.py 86.66% <0.00%> (-4.32%) ⬇️
sdk/python/feast/go_server.py 62.19% <0.00%> (-2.95%) ⬇️
...tion/feature_repos/integration_test_repo_config.py 100.00% <0.00%> (ø)
sdk/python/feast/infra/local.py 95.55% <0.00%> (+0.10%) ⬆️
sdk/python/tests/conftest.py 89.43% <0.00%> (+2.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae133fd...85a4074. Read the comment docs.

ci: Reintroduce redis services at 6379
85a4074 
Signed-off-by: Achal Shah <achals@gmail.com>
achals force-pushed the achal/reintro-redis branch 3 times, most recently from 940da68 to 85a4074 Compare March 10, 2022 19:07
achals changed the title Reintroduce redis services at 6379 ci: Reintroduce redis services at 6379 Mar 10, 2022
felixwang9817 requested changes Mar 10, 2022
View reviewed changes

felixwang9817 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

missed a supercharge

Comment thread .github/workflows/master_only.yml
felixwang9817 approved these changes Mar 10, 2022
View reviewed changes

felixwang9817 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

/lgtm

feast-ci-bot commented Mar 10, 2022

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [achals,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

feast-ci-bot merged commit 6498794 into feast-dev:master Mar 10, 2022
achals mentioned this pull request Mar 10, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

felixwang9817 felixwang9817 approved these changes
adchia Awaiting requested review from adchia adchia was automatically assigned from feast-dev/maintainers

Assignees

woop

felixwang9817

Labels

approved kind/housekeeping lgtm ok-to-test size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL