FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: Create __init__ files for the proto-generated python dirs by achals · Pull Request #2410 · feast-dev/feast · GitHub

/ feast Public

fix: Create __init__ files for the proto-generated python dirs #2410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 2 commits into from
Mar 15, 2022
Conversation 6 Commits 2 Checks 0 Files changed
Merged

fix: Create __init__ files for the proto-generated python dirs #2410

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a676b43
fix: Create __init__ files for the proto-generated python dirs
achals Mar 15, 2022
507cf5a
remove dupe import
achals Mar 15, 2022
File filter

Filter by extension

Filter by extension .py  (1) All 1 file type selected
Only manifest files
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
Prev Previous commit
remove dupe import 
Signed-off-by: Achal Shah <achals@gmail.com>
  • Loading branch information
achals committed Mar 15, 2022
commit 507cf5a4d60f6001c29486f794f6e10bcf8df138
4 changes: 1 addition & 3 deletions sdk/python/setup.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -210,11 +210,9 @@ def _generate_python_protos(self, path: str):
self.python_folder,
]
+ proto_files,
)
)

def run(self):
from pathlib import Path

for sub_folder in self.sub_folders:
self._generate_python_protos(f"feast/{sub_folder}/*.proto")
# We need the __init__ files for each of the generated subdirs
Expand Down
Back | FazBrowse Home | New Git URL