FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: Simplify DataSource.from_proto logic by achals · Pull Request #2424 · feast-dev/feast · GitHub

/ feast Public

fix: Simplify DataSource.from_proto logic #2424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 11 commits into from
Mar 22, 2022
Conversation 11 Commits 11 Checks 0 Files changed
Merged

fix: Simplify DataSource.from_proto logic #2424

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
07212b5
fix: Simplify DataSource.from_proto logic
achals Mar 20, 2022
e99fabe
simpler
achals Mar 21, 2022
a86fd8d
use enum instead
achals Mar 22, 2022
a6f9db2
rebase and add push
achals Mar 22, 2022
658f4e0
imports
achals Mar 22, 2022
886f97a
imports
achals Mar 22, 2022
fe3d69d
imports
achals Mar 22, 2022
772cc5c
CR
achals Mar 22, 2022
852c27e
Revert "CR"
achals Mar 22, 2022
03cf881
CR
achals Mar 22, 2022
30a3cf8
cr
achals Mar 22, 2022
File filter

Filter by extension

Filter by extension .proto  (1) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
Prev Previous commit
cr 
Signed-off-by: Achal Shah <achals@gmail.com>
  • Loading branch information
achals committed Mar 22, 2022
commit 30a3cf80e75e40582f9a08acc4e101e4773627a8
2 changes: 2 additions & 0 deletions protos/feast/core/DataSource.proto
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,8 @@ message DataSource {

// This is an internal field that is represents the python class for the data source object a proto object represents.
// This should be set by feast, and not by users.
// The field is used primarily by custom data sources and is mandatory for them to set. Feast may set it for
// first party sources as well.
string data_source_class_type = 17;

// Defines options for DataSource that sources features from a file
Expand Down
Back | FazBrowse Home | New Git URL