FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Empty response handling in serving api by pradithya · Pull Request #3 · feast-dev/feast · GitHub

/ feast Public

Empty response handling in serving api #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pradithya merged 1 commit into from
Dec 13, 2018
+0 −8
Conversation 0 Commits 1 Checks 0 Files changed 1
Merged

Empty response handling in serving api #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .java  (1) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
8 changes: 0 additions & 8 deletions serving/src/main/java/feast/serving/grpc/ServingGrpcService.java
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -77,14 +77,6 @@ public void queryFeatures(Request request, StreamObserver<Response> responseObse
Request validRequest = checkTimestampRange(request);
Response response = feast.queryFeatures(validRequest);

if (response.getEntitiesCount() < 1) {
responseObserver.onError(
new StatusRuntimeException(
Status.fromCode(NOT_FOUND)
.withDescription("No value is found for the requested feature")));
return;
}

innerSpan.log("calling onNext");
responseObserver.onNext(response);
innerSpan.log("calling onCompleted");
Expand Down
Back | FazBrowse Home | New Git URL